Add missing plugins in README.md for tracing the sample app #1509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I followed this guide I got some errors after running ```sh $ npm install \ @opentelemetry/core \ @opentelemetry/node \ @opentelemetry/plugin-http ``` The errors: PluginLoader#load: could not load plugin @opentelemetry/plugin-https of module https. Error: Cannot find module '@opentelemetry/plugin-https' and PluginLoader#load: could not load plugin @opentelemetry/plugin-express of module express. Error: Cannot find module '@opentelemetry/plugin-express' By adding those 2 plugins to the `npm install` I got that step working.
svrnm
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
|
|
Codecov Report
@@ Coverage Diff @@
## master #1509 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 154 154
Lines 4762 4762
Branches 951 951
=======================================
Hits 4468 4468
Misses 294 294 |
dyladan
approved these changes
Sep 9, 2020
mayurkale22
approved these changes
Sep 12, 2020
|
@dyladan @mayurkale22 sorry for asking this stupid question, but since this is my first pull request: is there anything I need to do? Also, I found 1 or 2 other things that might need to be changed in the getting started guide: should I put everything in one big PR or open multiple? |
naseemkullah
approved these changes
Sep 17, 2020
markwolff
approved these changes
Sep 17, 2020
I'd suggest to combine similar set of changes in one PR. |
mihirsoni
pushed a commit
to mihirsoni/opentelemetry-js
that referenced
this pull request
Sep 21, 2020
When I followed this guide I got some errors after running ```sh $ npm install \ @opentelemetry/core \ @opentelemetry/node \ @opentelemetry/plugin-http ``` The errors: PluginLoader#load: could not load plugin @opentelemetry/plugin-https of module https. Error: Cannot find module '@opentelemetry/plugin-https' and PluginLoader#load: could not load plugin @opentelemetry/plugin-express of module express. Error: Cannot find module '@opentelemetry/plugin-express' By adding those 2 plugins to the `npm install` I got that step working. Co-authored-by: Mayur Kale <mayurkale@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I followed this guide I got some errors after running
The errors:
PluginLoader#load: could not load plugin @opentelemetry/plugin-https of module https. Error: Cannot find module '@opentelemetry/plugin-https'
and
PluginLoader#load: could not load plugin @opentelemetry/plugin-express of module express. Error: Cannot find module '@opentelemetry/plugin-express'
By adding those 2 plugins to the
npm installI got that step working.I tried it with Node v10 and Node v14 and got the same results.