Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing plugins in README.md for tracing the sample app #1509

Merged
merged 2 commits into from
Sep 21, 2020
Merged

Add missing plugins in README.md for tracing the sample app #1509

merged 2 commits into from
Sep 21, 2020

Commits on Sep 9, 2020

  1. Add missing plugins for tracing the sample app

    When I followed this guide I got some errors after running 
    
    ```sh
    $ npm install \
      @opentelemetry/core \
      @opentelemetry/node \
      @opentelemetry/plugin-http
    ```
    
    The errors:
    PluginLoader#load: could not load plugin @opentelemetry/plugin-https of module https. Error: Cannot find module '@opentelemetry/plugin-https'
    and
    PluginLoader#load: could not load plugin @opentelemetry/plugin-express of module express. Error: Cannot find module '@opentelemetry/plugin-express'
    
    By adding those 2 plugins to the `npm install` I got that step working.
    svrnm authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    5252596 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2020

  1. Configuration menu
    Copy the full SHA
    1544503 View commit details
    Browse the repository at this point in the history