Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otlp-transformer): add missing prepublishOnly script #2998

Merged
merged 8 commits into from
Jun 1, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented May 27, 2022

@opentelemetry/otlp-transformer 0.29.1

  • fix(otlp-transformer): include missing prepublishOnly script which ensures esm and esnext build files are created and packaged

@dyladan dyladan requested a review from a team May 27, 2022 19:48
@dyladan
Copy link
Member Author

dyladan commented May 27, 2022

image

anybody know why some checks would be cancelled?

@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #2998 (f07c52f) into main (7649cf1) will decrease coverage by 0.89%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2998      +/-   ##
==========================================
- Coverage   92.65%   91.76%   -0.90%     
==========================================
  Files         185      178       -7     
  Lines        6144     5671     -473     
  Branches     1300     1212      -88     
==========================================
- Hits         5693     5204     -489     
- Misses        451      467      +16     
Impacted Files Coverage Δ
packages/opentelemetry-sdk-trace-web/src/utils.ts 65.62% <0.00%> (-29.38%) ⬇️
...emetry-instrumentation-xml-http-request/src/xhr.ts
...s/opentelemetry-instrumentation-fetch/src/fetch.ts
...es/opentelemetry-context-zone-peer-dep/src/util.ts
...mentation-xml-http-request/src/enums/EventNames.ts
...ation-xml-http-request/src/enums/AttributeNames.ts
...ry-context-zone-peer-dep/src/ZoneContextManager.ts
...-instrumentation-fetch/src/enums/AttributeNames.ts
packages/opentelemetry-resources/karma.worker.js 100.00% <0.00%> (+100.00%) ⬆️
...ckages/opentelemetry-sdk-trace-web/karma.worker.js 100.00% <0.00%> (+100.00%) ⬆️

@dyladan
Copy link
Member Author

dyladan commented May 27, 2022

I will release this as soon as we can get it approved and merged

@vmarchaud
Copy link
Member

image anybody know why some checks would be cancelled?

I had this in the past but that was linked to github actions runner, might some kind of outage

@pichlermarc
Copy link
Member

We'll have to bump the version and re-publish the dependents of @opentelemetry/otlp-transformer too, right? 🤔

@legendecas
Copy link
Member

legendecas commented May 30, 2022

@blumamir suggested we should release a new version of @opentelemetry/resources with #3004 so that test failing in the contrib repo can be fixed.

@dyladan dyladan changed the title fix(otlp-transformer): add missing prepublishOnly script and release new version fix(otlp-transformer): add missing prepublishOnly script Jun 1, 2022
@dyladan dyladan mentioned this pull request Jun 1, 2022
2 tasks
@dyladan dyladan added this to the Metrics GA milestone Jun 1, 2022
@dyladan
Copy link
Member Author

dyladan commented Jun 1, 2022

/easycla

@dyladan dyladan merged commit d10b254 into open-telemetry:main Jun 1, 2022
@dyladan dyladan deleted the prepublish-otlp-transformer branch June 1, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants