Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otlp-transformer): compile otlp-transformer before publishing #3012

Conversation

domasx2
Copy link
Contributor

@domasx2 domasx2 commented Jun 1, 2022

Which problem is this PR solving?

Esm and esnext builds are still not being included in the @opentelemetry/otlp-transformer npm package because it is not being compiled for these targets before publishing. This PR adds a prepublishOnly hook to compile, same as other packages.
Previous related PR towards this goal: #2992

Short description of the changes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • existing tests

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@domasx2 domasx2 requested a review from a team June 1, 2022 13:40
@dyladan
Copy link
Member

dyladan commented Jun 1, 2022

Duplicate of #2998

@dyladan dyladan marked this as a duplicate of #2998 Jun 1, 2022
@dyladan dyladan closed this Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants