Add key predicate to baggage span processor #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
May 22, 2024
codeboten
reviewed
May 22, 2024
processor/opentelemetry-processor-baggage/tests/test_baggage_processor.py
Show resolved
Hide resolved
codeboten
approved these changes
May 23, 2024
ocelotl
approved these changes
May 28, 2024
auto-merge was automatically disabled
May 28, 2024 18:35
Pull Request is not mergeable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the Baggage span processor to require a baggage key predicate function that selects what keys are copied to new spans.
Fixes #2472
Type of change
Please delete options that are not relevant.
(The original span processor PR Request for new component: Baggage Span Processor #2428 has been published yet so this is not breaking)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.