more linter fixes

processor/opentelemetry-processor-baggage/src/opentelemetry/processor/baggage/__init__.py

@@ -14,7 +14,7 @@
 
 # pylint: disable=import-error
 
-from .processor import BaggageSpanProcessor
+from .processor import ALLOW_ALL_BAGGAGE_KEYS, BaggageSpanProcessor
 from .version import __version__
 
-__all__ = ["BaggageSpanProcessor", "__version__"]
+__all__ = ["ALLOW_ALL_BAGGAGE_KEYS", "BaggageSpanProcessor", "__version__"]

processor/opentelemetry-processor-baggage/src/opentelemetry/processor/baggage/processor.py

@@ -19,15 +19,11 @@
 from opentelemetry.sdk.trace.export import SpanProcessor
 from opentelemetry.trace import Span
 
-"""
-A BaggageKeyPredicate is a function that takes a baggage key and returns a boolean
-"""
-type BaggageKeyPredicate = Callable[[str], bool]
+# A BaggageKeyPredicate is a function that takes a baggage key and returns a boolean
+BaggageKeyPredicateT = Callable[[str], bool]
 
-"""
-A BaggageKeyPredicate that always returns True, allowing all baggage keys to be added to spans
-"""
-ALLOW_ALL_BAGGAGE_KEYS: BaggageKeyPredicate = lambda baggageKey: True
+# A BaggageKeyPredicate that always returns True, allowing all baggage keys to be added to spans
+ALLOW_ALL_BAGGAGE_KEYS: BaggageKeyPredicateT = lambda _: True
 
 
 class BaggageSpanProcessor(SpanProcessor):
@@ -54,9 +50,8 @@ class BaggageSpanProcessor(SpanProcessor):
 
     """
 
-    def __init__(self, baggage_key_predicate: BaggageKeyPredicate) -> None:
+    def __init__(self, baggage_key_predicate: BaggageKeyPredicateT) -> None:
         self._baggage_key_predicate = baggage_key_predicate
-        pass
 
     def on_start(
         self, span: "Span", parent_context: Optional[Context] = None

processor/opentelemetry-processor-baggage/tests/test_baggage_processor.py

@@ -29,7 +29,9 @@
 
 class BaggageSpanProcessorTest(unittest.TestCase):
     def test_check_the_baggage(self):
-        self.assertIsInstance(BaggageSpanProcessor(), SpanProcessor)
+        self.assertIsInstance(
+            BaggageSpanProcessor(ALLOW_ALL_BAGGAGE_KEYS), SpanProcessor
+        )
 
     def test_set_baggage_attaches_to_child_spans_and_detaches_properly_with_context(
         self,
@@ -156,8 +158,10 @@ def test_set_baggage_attaches_to_child_spans_and_detaches_properly_with_token(
         detach(honey_token)
         self.assertEqual(get_all_baggage(), {})
 
+    @staticmethod
     def has_prefix(baggage_key: str) -> bool:
         return baggage_key.startswith("que")
 
+    @staticmethod
     def matches_regex(baggage_key: str) -> bool:
         return re.match(r"que.*", baggage_key) is not None