-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
args is an array of strings #416
Conversation
LGTM, but the commit is not signed (try |
Thanks @vbatts , updated the diff. |
Signed-off-by: Amit Saha <amitsaha.in@gmail.com>
Probably not a big deal, but there seems to have been a metadata fumble merging this PR:
It looks like @vbatts also cherry-picked and clobbered author-dates when pushing #414, #413, #410, and #406 to master without merge commits (although this is the only PR where the author email changed). I'm not sure what lead to that, and we're back to the usual GitHub merges by #422. Was that just a bad day, or is there something we can do to make PRs more easily mergable? |
I was seeing that in On Sat, May 7, 2016 at 7:09 AM, W. Trevor King notifications@github.com
|
Signed-off-by: Amit Saha <amitsaha.in@gmail.com>
"args" is an array of strings, not a string.
Signed-off-by: Amit Saha amitsaha.in@gmail.com