Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Config] Capitalize MUST in config.md #438

Merged
merged 1 commit into from
May 20, 2016
Merged

[Config] Capitalize MUST in config.md #438

merged 1 commit into from
May 20, 2016

Conversation

RobDolinMS
Copy link
Collaborator

"must" --> "MUST" for RFC 2119 compliance

This replaces PR #403 which required a rebase

Signed-off-by: Rob Dolin RobDolin@microsoft.com

@RobDolinMS
[Config] Capitalize MUST in config.md
035713e 
"must" --> "MUST" for RFC 2119 compliance

This replaces PR opencontainers#403 which required a rebase

Signed-off-by: Rob Dolin <RobDolin@microsoft.com>
@RobDolinMS RobDolinMS mentioned this pull request May 18, 2016
Closed
@crosbymichael
Copy link
Member

LGTM

@wking
Copy link
Contributor

wking commented May 18, 2016

On Wed, May 18, 2016 at 11:22:58AM -0700, Rob Dolin (MSFT) wrote:

This replaces PR #403 which required a rebase

With 035713e, the only content changes I see since #403 are ‘string’ →
‘array of strings’ for args/env (from #416?). So I think my old
comments [1,2] still apply.

@mrunalp
Copy link
Contributor

mrunalp commented May 20, 2016

LGTM

@mrunalp mrunalp merged commit 5d27f3a into opencontainers:master May 20, 2016
@RobDolinMS RobDolinMS deleted the patch-2 branch September 1, 2016 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RobDolinMS @crosbymichael @wking @mrunalp