-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reuses and datasets with no private attribute #2951
Conversation
c83762f
to
731fdd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Don't forget the changelog ;)
I'm wondering if we can have the same issue with Datasets?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix!
I think the migration doesn't work as is due to mongoengine Document logic.
udata/migrations/2024-01-29-fix-reuse-and-dataset-with-private-None.py
Outdated
Show resolved
Hide resolved
udata/migrations/2024-01-29-fix-reuse-and-dataset-with-private-None.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this fix!
udata/migrations/2024-01-29-fix-reuse-and-dataset-with-private-None.py
Outdated
Show resolved
Hide resolved
…-None.py Co-authored-by: maudetes <maudet.estelle@gmail.com>
Fix datagouv/data.gouv.fr#1262