Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reuses and datasets with no private attribute #2951

Merged
merged 8 commits into from
Feb 7, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion udata/core/reuse/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class Reuse(db.Datetimed, WithMetrics, BadgeMixin, db.Owned, db.Document):
topic = db.StringField(required=True, choices=list(REUSE_TOPICS))
# badges = db.ListField(db.EmbeddedDocumentField(ReuseBadge))

private = db.BooleanField()
private = db.BooleanField(required=True, default=False)

ext = db.MapField(db.GenericEmbeddedDocumentField())
extras = db.ExtrasField()
Expand Down
23 changes: 23 additions & 0 deletions udata/migrations/2024-01-29-fix-reuse-with-private-None.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
'''
Some old reuse don't have a `private` field. It should be False by default.
'''
import logging

from udata.models import Reuse

log = logging.getLogger(__name__)


def migrate(db):
log.info('Processing Reuse.')

reuses = Reuse.objects().no_cache().timeout(False)
count = 0
for reuse in reuses:
if reuse.private == None:
reuse.private = False
reuse.save()
count += 1

log.info(f'Fixed {count} Reuses objects from private None to private False.')
log.info('Done')