chore: remove warnings from defusedxml package #32616
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ulestore.update_item()
In a refactor, this call to runtime.publish didn't actually match the API properly, causing runtime errors on LMS.
…ods (openedx#32210) * fix: return 403 on course access error rather than redirect
* fix: fixing test. * fix: updating exceptions.
This makes a couple of changes to the xblock handler in the CMS. These changes add a handful of utility functions and modify the existing ones to make reuse of existing blocks easier. With these changes, it is possible to copy an entire section from one course to another, and then later refresh that section, and all of its children, without destroying the blocks next to it. The existing _duplicate_block function was modified to have a shallow keyword to avoid copying children, and the update_from_source function was added to make it easy to copy attributes over from one block to another. These functions can be used alongside copy_from_template in the modulestore to copy over blocks and their children without requiring them to be within any particular container (other than a library or course root)-- thus allowing library-like inclusion without the library content block. This is especially useful for cases like copying sections rather than unit content.
…enedx#32286) For the XBlocks types that use legacy XModule-style assets (specifically, those that inherit from `HTMLSnippet`), this is small refactor that brings them a bit closer to being like standard XBlocks. Given these class attributes: class SomeXModuleLikeBlock(..., HTMLSnippet, ...): ... studio_view_css = { ... } preview_view_css = { ... } studio_view_js = { ... } preview_view_js = { ... } ... we make it so their values are *paths to the resources* rather than *the actual content of the resources*. This is a no-op change, but it'll enable future XModule asset refactorings which require us to operate on asset paths rather than contents. Part of: openedx#32292
…terprise-version-3.65.0 chore: bumping enterprise package version to 3.65.1
Adds a filter to modify course_home_url Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`
…-openedx-filters-d59f5f0 feat: Upgrade Python dependency openedx-filters
openedx#32305) * feat: allow course entitlements REST API to be filtered on course_uuid * feat: add field to filter out entitlements with null expired_at values * chore: update tests
…terprise-version-3.65.2 chore: bumping enterprise package version to 3.65.2
-> bind_for_student() and friends change the user_id -> DraftVersioningModuleStore.update_item() mutates .location which mutates scope_ids.def_id and scope_ids.usage_id in a way that seems totally wrong
…urses chore: linting chore: update requested change
We are lacking information in Flower about our Celery tasks that are marked as successful but are actually failing. Attempt to remove ignore_result=True to see if this is suppressing valuable debugging information.
…ate_entitlements_command temp: save results & add tests/fixes for expire_and_create_entitlements
…d-logging temp: added standard logging and removed celery logging
chore: edx-enterprise version bump
chore: edx-enterprise version bump
…terprise-version-3.67.5 chore: bumping enterprise package version to 3.67.5
…edx#32346) * refactor: improve typing of StaticFile named tuple * feat: copy static asset files into the clipboard * feat: paste static assets * feat: show notification in studio about pasted assets * fix: HTML XBlocks would lose the editor="raw" setting when copy-pasted. * feat: copy python_lib.zip to the clipboard when it seems to be in use
* point to upstream repos, not eduNEXT forks * link to guides, not just source repos * fix spelling of Open edX
…2593) * fix: field adjustments to product recommendations endpoint * chore: formatting for files * chore: indenting fix * chore: removed f-strings
…terprise-version-3.67.6 chore: bumping enterprise package version to 3.67.6
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @diegovr! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate. |
|
@diegovr Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: openedx/public-engineering#146
defusedxmlpackage which will no longer be supported.python3.8) supports thexml.etree.ElementTreepackage which replace the old package (defusedxml).Supporting information
The best references to why it was deprecated I could find are here:
Testing instructions
To check and find from where I get the same warning, I run the unit tests inside the
lmscontainer (by runningmake dev.shell.lms) and I could found that the tests which use the deprecated package are fromopenedx/core/lib/tests/path so I usedpytestto confirm that.Then after the changes I re-run the tests and the warning no longer appeared.
Other information
defusedxmlpackage since is used only in this section.