[Workspace]Following pr for #5949 #6012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn,
ruanyl and
BionIT
as code owners
SuZhou-Joe
added
Skip-Changelog
7 tasks
ruanyl
approved these changes
Mar 4, 2024
ashwin-pc
approved these changes
Mar 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6012 +/- ##
=======================================
Coverage 67.10% 67.10%
=======================================
Files 3315 3315
Lines 63904 63904
Branches 10220 10220
=======================================
Hits 42880 42880
- Misses 18539 18540 +1
+ Partials 2485 2484 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 4, 2024
…ct#6012) * feat: temp save Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add some comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Mar 4, 2024
…ct#6012) * feat: temp save Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add some comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
SuZhou-Joe
added a commit
to ruanyl/OpenSearch-Dashboards
that referenced
this pull request
Mar 5, 2024
SuZhou-Joe
added a commit
to ruanyl/OpenSearch-Dashboards
that referenced
this pull request
Mar 5, 2024
SuZhou-Joe
added a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Apr 10, 2024
…ct#6012) * feat: temp save Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add some comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
SuZhou-Joe
added a commit
that referenced
this pull request
Apr 11, 2024
) (#6387) * [Workspace]Optional workspaces params in repository (#5949) * refact: move workspace specific logic to savedObjectWrapper Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: some error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: fix test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless config in test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add CHANGELOG Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add more unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: revert test in repository.test.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: revert test in import_saved_objects.test.ts Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: revert test in repository.test.js Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add type Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bootstrap type error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code and add comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: integration test fail Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add missing code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: optimize code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Add permissions field to the mapping only if the permission control is enabled Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix test failure Signed-off-by: gaobinlong <gbinlong@amazon.com> * feat: modify unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bulk create error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: bulk create error Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add new config in yml file Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add new config in yml file Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update yml file Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: fix unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: do not skip migration when doing integration test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: remove useless code Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change flag variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add test cases Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> Co-authored-by: gaobinlong <gbinlong@amazon.com> (cherry picked from commit c6b4c34) * [Workspace]Following pr for #5949 (#6012) * feat: temp save Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add some comment Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration