feat: cherry-pick pr #5949 #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## workspace #274 +/- ##
=============================================
- Coverage 66.76% 66.76% -0.01%
=============================================
Files 3337 3337
Lines 64801 64810 +9
Branches 10453 10456 +3
=============================================
+ Hits 43263 43269 +6
- Misses 18951 18953 +2
- Partials 2587 2588 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
ruanyl
reviewed
Mar 4, 2024
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Hailong-am
approved these changes
Mar 4, 2024
| @@ -34,6 +34,7 @@ | |||
|
|
|||
| import crypto from 'crypto'; | |||
| import { cloneDeep, mapValues } from 'lodash'; | |||
| import { Config } from 'packages/osd-config/target'; | |||
There was a problem hiding this comment.
shall we merge opensearch-project#6012 to this one or will have another cherry-pick for 6012?
There was a problem hiding this comment.
Will have another cherry-pick.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integration