Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1872802: remove old MCO etcd quorum guard resources #429

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Aug 26, 2020

This cleans up the old mco pdb after the new one is in place. It may fight with and old MCO operator, but only until that operator gets its new deployment.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2020
@hexfusion
Copy link
Contributor

hexfusion commented Aug 26, 2020

/lgtm

cc @cgwalters @kikisdeliveryservice we feel that my changes in mco#1933 exposed a failure case that is blocking CI promotion.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, hexfusion

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k changed the title remove old MCO etcd quorum guard resources bug 1872802; remove old MCO etcd quorum guard resources Aug 26, 2020
@deads2k deads2k changed the title bug 1872802; remove old MCO etcd quorum guard resources bug 1872802: remove old MCO etcd quorum guard resources Aug 26, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 26, 2020
@openshift-ci-robot
Copy link

@deads2k: This pull request references Bugzilla bug 1872802, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

bug 1872802: remove old MCO etcd quorum guard resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@kikisdeliveryservice
Copy link
Contributor

kikisdeliveryservice commented Aug 26, 2020

/lgtm

cc @cgwalters @kikisdeliveryservice we feel that my changes in mco#1933 exposed a failure case that is blocking CI promotion.

@hexfusion
Would you prefer to go with this PR instead of the MCO PR or are we doing both?

@hexfusion
Copy link
Contributor

hexfusion commented Aug 26, 2020

/lgtm
cc @cgwalters @kikisdeliveryservice we feel that my changes in mco#1933 exposed a failure case that is blocking CI promotion.

@hexfusion
Would you prefer to go with this PR instead of the MCO PR or are we doing both?

this is just about to merge I am testing upgrade in clusterbot as well. I am going to raise a partial revert on #1933 in case.

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-gcp/1298724636363591680

@hexfusion
Copy link
Contributor

/refresh

@hexfusion
Copy link
Contributor

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 26, 2020

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure ef8fd02 link /test e2e-azure
ci/prow/e2e-aws-disruptive ef8fd02 link /test e2e-aws-disruptive
ci/prow/e2e-metal-ipi ef8fd02 link /test e2e-metal-ipi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@hexfusion
Copy link
Contributor

hexfusion commented Aug 26, 2020

test upgrade quay.io/openshift-release-dev/ocp-release:4.5.7-x86_64 registry.svc.ci.openshift.org/ci-op-hhyj4fic/release:latest 

Clusterbot minor upgrade was a success.

https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/release-openshift-origin-installer-launch-gcp/1298724636363591680

@openshift-merge-robot openshift-merge-robot merged commit efaf6bf into openshift:master Aug 26, 2020
@openshift-ci-robot
Copy link

@deads2k: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872802 has not been moved to the MODIFIED state.

In response to this:

bug 1872802: remove old MCO etcd quorum guard resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants