bug 1872802: revert of Bug 1868117: cleanup: remove legacy etcd bits

[deads2k]

revert #1933 which appears to break upgrade 4.5 to 4.6

[openshift-ci-robot]

@deads2k: This pull request references Bugzilla bug 1868117, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

revert of Bug 1868117: cleanup: remove legacy etcd bits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

cc: @hexfusion

[cgwalters]

That's unfortunate 😢
/approve

Hm, I guess we don't have a job hooked up to repos for 4.5 upgrades yet.

[kikisdeliveryservice]

@deads2k do we have any data points showing that this broke upgrades? can we get a bz with a summary laying this out?

Is there any potential for leaving these bits behind that will cause issues as well?

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deads2k]

one better fix that isn't yet proven here: openshift/cluster-etcd-operator#429

[deads2k]

https://bugzilla.redhat.com/show_bug.cgi?id=1872802

[openshift-ci-robot]

@deads2k: This pull request references Bugzilla bug 1872802, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

bug 1872802: revert of Bug 1868117: cleanup: remove legacy etcd bits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kikisdeliveryservice]

Asked in openshift/cluster-etcd-operator#429 but are we trying that one in lieu of this PR? Or are we merging both?

[openshift-ci-robot]

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-ovn-step-registry	7ae22fc	link	/test e2e-ovn-step-registry
ci/prow/okd-e2e-aws	7ae22fc	link	/test okd-e2e-aws
ci/prow/e2e-aws-workers-rhel7	7ae22fc	link	/test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[kikisdeliveryservice]

Looks like after merging the other PR upgrades were successful see: openshift/cluster-etcd-operator#429 (comment)

So I think we don't need this PR anymore? But I'll let @deads2k / @hexfusion give the official word.

[hexfusion]

/hold

[deads2k]

upgrades are green now

/close

[openshift-ci-robot]

@deads2k: Closed this PR.

In response to this:

upgrades are green now

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@deads2k: This pull request references Bugzilla bug 1872802. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

bug 1872802: revert of Bug 1868117: cleanup: remove legacy etcd bits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.