-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/group tags like mzm #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ziet er goed uit.
Alleen een vraag: waarom noem je het hier 'theme' terwijl het 'type' heet in de API? En overlapt dat niet met het meest voor de hand liggende type 'theme' dat we straks gaan gebruiken?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top, tnx
* Make it possible to set the href on the counter * Set counterUrl without lodash lib * Add a message when the widget is used on a non-idea resource page and when you are logged in as admin, moderator or editor * Made it so the title can be changed of the succesfull voting message * Added field to phase-voting-budgeting * Corrected spelling * Corrected spelling * Changed spelling of successful * Changed spelling of step_3_successful_auth * changed spelling in label of field * Added message closed but open for admin / editor / moderator * Update packages/cms/lib/modules/arguments-block-widgets/index.js Co-authored-by: Rudi van Hierden <rudi@draad.nl> * Update packages/cms/lib/modules/arguments-block-widgets/views/widget.html Co-authored-by: Rudi van Hierden <rudi@draad.nl> * Aloow for multiple tabs sections on a page * Make js uglifyable * Added fallback text because if you did not commit on a preexisting form then the message will not be rendered * Feature/group tags like mzm (#386) * Added grouping capabilities to tags on ideas(plannen) on create plannen page * Added tagid to checbox and label instead of non working option * specify if theme labels should be shown * Made it so tags can be grouped by use of extraData.theme * Changed default of showing labels to false for and made name consistent * Changed implementation to use type * Put back cache * Renamed theme fields to tagType * Added cache key for if an empty list was fetched * Added cachekey for empty list * Bugfix/tags remember choices on edit idea (#389) * added forgotten groupedTags from cache * Clean up test code * Added fallback when choosing static form with dynamic fields --------- Co-authored-by: Rudi van Hierden <rudi@draad.nl> Co-authored-by: Niels Vegter <niels@denes.nl>
* Make it possible to set the href on the counter * Set counterUrl without lodash lib * Add a message when the widget is used on a non-idea resource page and when you are logged in as admin, moderator or editor * Made it so the title can be changed of the succesfull voting message * Added field to phase-voting-budgeting * Corrected spelling * Corrected spelling * Changed spelling of successful * Changed spelling of step_3_successful_auth * changed spelling in label of field * Added message closed but open for admin / editor / moderator * Update packages/cms/lib/modules/arguments-block-widgets/index.js Co-authored-by: Rudi van Hierden <rudi@draad.nl> * Update packages/cms/lib/modules/arguments-block-widgets/views/widget.html Co-authored-by: Rudi van Hierden <rudi@draad.nl> * Aloow for multiple tabs sections on a page * Make js uglifyable * Added fallback text because if you did not commit on a preexisting form then the message will not be rendered * Feature/group tags like mzm (#386) * Added grouping capabilities to tags on ideas(plannen) on create plannen page * Added tagid to checbox and label instead of non working option * specify if theme labels should be shown * Made it so tags can be grouped by use of extraData.theme * Changed default of showing labels to false for and made name consistent * Changed implementation to use type * Put back cache * Renamed theme fields to tagType * Added cache key for if an empty list was fetched * Added cachekey for empty list * Bugfix/tags remember choices on edit idea (#389) * added forgotten groupedTags from cache * Clean up test code * Added fallback when choosing static form with dynamic fields * make inzendingPath the same as global config > ideaSlug (#392) * Changed reading of activeResource param in html (#393) --------- Co-authored-by: Rudi van Hierden <rudi@draad.nl> Co-authored-by: Niels Vegter <niels@denes.nl>
Make it possible to use Tag type column to create grouped taglists. Dependent on openstad/openstad-api#293