Bugfix/tags remember choices on edit idea #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LorenzoJokhan
requested review from
nlsvgtr and
rudivanhierden
and removed request for
Badmuts
rudivanhierden
approved these changes
Apr 13, 2023
LorenzoJokhan
added a commit
that referenced
this pull request
Apr 20, 2023
* Make it possible to set the href on the counter * Set counterUrl without lodash lib * Add a message when the widget is used on a non-idea resource page and when you are logged in as admin, moderator or editor * Made it so the title can be changed of the succesfull voting message * Added field to phase-voting-budgeting * Corrected spelling * Corrected spelling * Changed spelling of successful * Changed spelling of step_3_successful_auth * changed spelling in label of field * Added message closed but open for admin / editor / moderator * Update packages/cms/lib/modules/arguments-block-widgets/index.js Co-authored-by: Rudi van Hierden <rudi@draad.nl> * Update packages/cms/lib/modules/arguments-block-widgets/views/widget.html Co-authored-by: Rudi van Hierden <rudi@draad.nl> * Aloow for multiple tabs sections on a page * Make js uglifyable * Added fallback text because if you did not commit on a preexisting form then the message will not be rendered * Feature/group tags like mzm (#386) * Added grouping capabilities to tags on ideas(plannen) on create plannen page * Added tagid to checbox and label instead of non working option * specify if theme labels should be shown * Made it so tags can be grouped by use of extraData.theme * Changed default of showing labels to false for and made name consistent * Changed implementation to use type * Put back cache * Renamed theme fields to tagType * Added cache key for if an empty list was fetched * Added cachekey for empty list * Bugfix/tags remember choices on edit idea (#389) * added forgotten groupedTags from cache * Clean up test code * Added fallback when choosing static form with dynamic fields --------- Co-authored-by: Rudi van Hierden <rudi@draad.nl> Co-authored-by: Niels Vegter <niels@denes.nl>
LorenzoJokhan
added a commit
that referenced
this pull request
May 5, 2023
* Make it possible to set the href on the counter * Set counterUrl without lodash lib * Add a message when the widget is used on a non-idea resource page and when you are logged in as admin, moderator or editor * Made it so the title can be changed of the succesfull voting message * Added field to phase-voting-budgeting * Corrected spelling * Corrected spelling * Changed spelling of successful * Changed spelling of step_3_successful_auth * changed spelling in label of field * Added message closed but open for admin / editor / moderator * Update packages/cms/lib/modules/arguments-block-widgets/index.js Co-authored-by: Rudi van Hierden <rudi@draad.nl> * Update packages/cms/lib/modules/arguments-block-widgets/views/widget.html Co-authored-by: Rudi van Hierden <rudi@draad.nl> * Aloow for multiple tabs sections on a page * Make js uglifyable * Added fallback text because if you did not commit on a preexisting form then the message will not be rendered * Feature/group tags like mzm (#386) * Added grouping capabilities to tags on ideas(plannen) on create plannen page * Added tagid to checbox and label instead of non working option * specify if theme labels should be shown * Made it so tags can be grouped by use of extraData.theme * Changed default of showing labels to false for and made name consistent * Changed implementation to use type * Put back cache * Renamed theme fields to tagType * Added cache key for if an empty list was fetched * Added cachekey for empty list * Bugfix/tags remember choices on edit idea (#389) * added forgotten groupedTags from cache * Clean up test code * Added fallback when choosing static form with dynamic fields * make inzendingPath the same as global config > ideaSlug (#392) * Changed reading of activeResource param in html (#393) --------- Co-authored-by: Rudi van Hierden <rudi@draad.nl> Co-authored-by: Niels Vegter <niels@denes.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ook meteen meegenomen dat het redirecten na submitten niet gaat wanneer je tags toevoegt. Dit om de een of andere reden, zorgt ervoor dat het nodige redirect veld buiten de form wordt gerenderd. Heb voor de snelste fallback gekozen om te kijken met queryselector of er een redirect veld uberhaupt aanwezig is. Bij het toevoegen van de tag section aan het form, is het wellicht nodig om eerst te refreshen voordat de geselecteerde tags worden laten zien