Remove torchvision from dependency list #504
Conversation
|
|
||
| TORCH_VERSION = "1.7.0" | ||
| TORCHVISION_VERSION = "0.8.1" | ||
| CUDA_VERSION = "102" | ||
| IS_CUDA_VER_DEFAULT_FOR_CURRENT_TORCH_VER = True | ||
|
|
There was a problem hiding this comment.
Why we need TORCHVISION_SOURCE_URL_TEMPLATE in 80 line if it is not used any more?
There was a problem hiding this comment.
you are right; removed
| ``` | ||
| pip install examples/requirements.txt | ||
| ``` | ||
|
|
There was a problem hiding this comment.
We already have this in root README.md. It doesn't hurt to give another hint at sample README level, though, but you should do this for each sample then.
There was a problem hiding this comment.
mb pip install **-r** examples/requirement.txt ?
There was a problem hiding this comment.
@vshampor It seems to be more convenient for users.
I did for classification, detection and segmentation. Do we have more?
There was a problem hiding this comment.
mb
pip install **-r** examples/requirement.txt?
Should be. Need to change main Readme
There was a problem hiding this comment.
@aleksei-kashapov please adjust the root README as well within the scope of this PR.
kshpv
force-pushed
the
unnecessary_dependency
branch
from
15dcd95
to
37dfb62
Compare
* Remove torchvision from dependency list * Fix bug * Add installation part to samples readme * Update install instruction
No description provided.