Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove torchvision from dependency list #504

Merged
merged 4 commits into from
Feb 20, 2021
Merged

Remove torchvision from dependency list #504

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca6c1be
Remove torchvision from dependency list
kshpv Feb 12, 2021
68abac2
Fix bug
kshpv Feb 15, 2021
1466f9e
Add installation part to samples readme
kshpv Feb 15, 2021
37dfb62
Update install instruction
kshpv Feb 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove torchvision from dependency list
  • Loading branch information
@kshpv
kshpv committed Feb 17, 2021
commit ca6c1be5d32a6683d360cfdc0ed537365401c862
1 change: 1 addition & 0 deletions examples/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ defusedxml>=0.7.0rc1
mlflow>=1.12.1
returns==0.14
opencv-python>=4.4.0.46
torchvision==0.8.1
13 changes: 1 addition & 12 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,9 @@ def find_version(*file_paths):

version_string = "{}{}".format(sys.version_info[0], sys.version_info[1])

INSTALL_REQUIRES.extend(["torch", "torchvision"])
INSTALL_REQUIRES.extend("torch")
0de554K marked this conversation as resolved.
Show resolved Hide resolved

TORCH_VERSION = "1.7.0"
TORCHVISION_VERSION = "0.8.1"
CUDA_VERSION = "102"
IS_CUDA_VER_DEFAULT_FOR_CURRENT_TORCH_VER = True

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need TORCHVISION_SOURCE_URL_TEMPLATE in 80 line if it is not used any more?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right; removed

Expand All @@ -90,11 +89,6 @@ def find_version(*file_paths):
tv=TORCH_VERSION,
ver=version_string,
mode=mode,
whl_mode=whl_mode),
TORCHVISION_SOURCE_URL_TEMPLATE.format(
tvv=TORCHVISION_VERSION,
ver=version_string,
mode=mode,
whl_mode=whl_mode)]
sys.argv.remove("--cpu-only")
else:
Expand All @@ -105,11 +99,6 @@ def find_version(*file_paths):
tv=TORCH_VERSION,
ver=version_string,
mode=mode,
whl_mode=whl_mode),
TORCHVISION_SOURCE_URL_TEMPLATE.format(
tvv=TORCHVISION_VERSION,
ver=version_string,
mode=mode,
whl_mode=whl_mode)]


Expand Down