Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[change] Metric collection: add consent in web UI #372

Closed
nemesifier opened this issue Mar 5, 2024 · 0 comments · Fixed by #378
Closed

[change] Metric collection: add consent in web UI #372

nemesifier opened this issue Mar 5, 2024 · 0 comments · Fixed by #378
Labels
enhancement

Comments

@nemesifier
Copy link
Member

nemesifier commented Mar 5, 2024 •
edited
Loading

Improvements discussed recently:

  • Add the consent screen to the system info page (we'll need to make sure only superusers can see/change this), we'll keep it enabled by default
  • If necessary, move metric collection to one of the existing subapps (optional)

We need to find a way to notify users the first time they access the system. We could simply use the Django message framework and produce a message the first time a super user logs in or anything equivalent.

More notes

  • We want to show an info message in the admin, but we want to show it only once, the info message will contain a link to the system info page and inform the user they can opt out
  • In the system info page we can have an additional template block which shows a consent checkbox which can be turned off (opt out)
  • We probably need to change the index() view of OpenwispAdminSite
  • It's not a problem that admin_theme will be slightly aware of the measurements app
@nemesifier nemesifier changed the title [change] Metric collection: move to existing subapp [change] Metric collection: move to existing subapp & add consent in web UI Mar 6, 2024
@nemesifier nemesifier changed the title [change] Metric collection: move to existing subapp & add consent in web UI [change] Metric collection: add consent in web UI Apr 5, 2024
pandafy added a commit that referenced this issue Apr 15, 2024
@pandafy
[change] Metric collection: added consent in web UI #372
7c9781e 
Closes #372
@pandafy pandafy mentioned this issue Apr 15, 2024
Merged
6 tasks
pandafy added a commit that referenced this issue Apr 15, 2024
@pandafy
[change] Metric collection: added consent in web UI #372
864ab2d 
Closes #372
pandafy added a commit that referenced this issue Apr 15, 2024
@pandafy
[change] Metric collection: added consent in web UI #372
89a4b60 
Closes #372
pandafy added a commit that referenced this issue Apr 15, 2024
@pandafy
[change] Metric collection: added consent in web UI #372
a6f8f23 
Closes #372
pandafy added a commit that referenced this issue Apr 15, 2024
@pandafy
[change] Metric collection: added consent in web UI #372
fee1f50 
Closes #372
pandafy added a commit that referenced this issue Apr 17, 2024
@pandafy
[change] Metric collection: added consent in web UI #372
e186d14 
Closes #372
nemesifier added a commit that referenced this issue Apr 23, 2024
@pandafy @nemesifier
[change] Metric collection: added consent logic to admin UI #372
1d3b00c 
* Added info message to admin UI (only once and only for super users)
* Added a consent form to openwisp-info page
* Changed app name from "openwisp_utils.measurements" to "openwisp_utils.metric_collection"
* Refactored code to reduce verbosity

Closes #372

---------

Co-authored-by: Federico Capoano <f.capoano@openwisp.io>
@nemesifier nemesifier mentioned this issue Apr 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[change] Metric collection: added consent in web UI #372 openwisp/openwisp-utils
1 participant
@nemesifier