[change] Metric collection: added consent in web UI #372 #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandafy
force-pushed
the
issues/372-metric-collection-web-consent
branch
4 times, most recently
from
a6f8f23
to
fee1f50
Compare
nemesifier
requested changes
Apr 16, 2024
There was a problem hiding this comment.
See my changes to the README here: 95c8e9a, please mention the possibility of removing consent from the UI there too.
| <h2>Metric collection</h2> | ||
| <form method="POST" id="id_metric_collection_consent_form"> | ||
| {% csrf_token %} | ||
| {{ metric_consent_form }} |
There was a problem hiding this comment.
Please rewrite this so that we can have the input first and each line wrapped on a <p> element, the current output is not readable.
You probably need to add:
margin-right: 8px;
vertical-align: top;
To the checkbox input to make it look decent:
There was a problem hiding this comment.
I just used some CSS to achieve the same result. Re-writing this would require copying some code from Django which we will need to maintain over time.
pandafy
force-pushed
the
issues/372-metric-collection-web-consent
branch
from
cd6c684
to
7cb4720
Compare
pandafy
force-pushed
the
issues/372-metric-collection-web-consent
branch
from
7cb4720
to
5799c8c
Compare
…utils.metrics_collection"
- renamed metrics_collection to metric_collection - reduced verbosity - isolated code meant to be used in admin_theme.admin - avoided used of term "disclaimer" - moved most of the code in class methods of models.OpenwispVersion
nemesifier
approved these changes
Apr 23, 2024
nemesifier
added a commit
to openwisp/ansible-openwisp2
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #372
Changes
Screenshots
Checklist