Adds toString for Endpoint debugging #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally this would be json so it matches other ones. I think zipkin.Endpoint is json string. If there's anything existing converter I might suggest changing to zipkin then to string. This will make ip addresses far easier to read. |
codefromthecrypt
pushed a commit
that referenced
this pull request
Oct 1, 2016
This adds Endpoint.toString for debugging. It uses json encoding so that it is easier to compare with spans in zipkin. Fixes #245
codefromthecrypt
pushed a commit
to openzipkin/zipkin
that referenced
this pull request
Oct 1, 2016
This is helpful for debugging instrumentation, particularly their local endpoints. See openzipkin/brave#245
codefromthecrypt
pushed a commit
to openzipkin/zipkin
that referenced
this pull request
Oct 1, 2016
This is helpful for debugging instrumentation, particularly their local endpoints. See openzipkin/brave#245
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.