Adds Endpoint.toString that matches json #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schlosna I realized this wasn't as easy since we don't format json on endpoint upstream. took the punch to do the work. let me know if this works for you |
|
@schlosna tomorrow I'll update base library to zipkin 1.13 which simplifies this as we just need to convert to zipkin.Endpoint then call toString(). afterwards will shortly release a Brave, assuming you're ok with the Reporter stuff sitting in master. |
This adds Endpoint.toString for debugging. It uses json encoding so that it is easier to compare with spans in zipkin.
codefromthecrypt
force-pushed
the
inetaddress-toString
branch
from
d3de3cd
to
da3608b
Compare
|
bumped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Endpoint.toString for debugging. It uses json encoding so that
it is easier to compare with spans in zipkin.
Fixes #245