Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor recommendation packages #2910

Merged
merged 69 commits into from
Jun 25, 2024

Conversation

felixhaeberle
Copy link
Contributor

@felixhaeberle felixhaeberle commented Jun 10, 2024


In his PR, we

  • renamed cross-sell-X packages to recommend-X to be more descriptive
  • refactor recommendation view to Sherlock VS Code extension
  • introduce new shouldRecommend function to @inlang/recommend-sherlock & @inlang/recommend-ninja

cc @NiklasBuchfink needs your review after I'm done.

Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: 5996c15

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@inlang/recommend-sherlock Minor
@inlang/recommend-ninja Minor
@inlang/paraglide-js Minor
vs-code-extension Minor
@inlang/paraglide-next Patch
@inlang/paraglide-sveltekit Patch
@inlang/paraglide-unplugin Patch
@inlang/paraglide-js-e2e Patch
@inlang/paraglide-sveltekit-example Patch
@inlang/paraglide-next-example-app Patch
@inlang/paraglide-next-example-pages Patch
@inlang/paraglide-next-example-turbo Patch
@inlang/paraglide-next-e2e Patch
@inlang/paraglide-rollup Patch
@inlang/paraglide-vite Patch
@inlang/paraglide-webpack Patch
@inlang/paraglide-astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felixhaeberle felixhaeberle self-assigned this Jun 10, 2024
felixhaeberle and others added 19 commits June 18, 2024 12:31
@felixhaeberle
Copy link
Contributor Author

felixhaeberle commented Jun 25, 2024

@LorisSigrist | @NiklasBuchfink, please review this for your apps and see if everything regarding the recommendations is working correctly?

@LorisSigrist I went for a patch change, but we should potentially do a minor one. Furthermore, I changed the package names. If I remember correctly, you already did this with the paraglide packages. Do you know if I have to look after something regarding npm publishing?

@felixhaeberle felixhaeberle changed the title cross sell ninja in sherlock | Sherlock 🕵️‍♂️ refactor recommendation packages Jun 25, 2024
@LorisSigrist
Copy link
Collaborator

We should probably do a "minor" patch for packages using it, as "patch" changes are usually not taken as seriously by module-resolvers.

As for the renaming: I don't think anything is going to break, but i would mark the old packages as depreciated on npm via the npm cli

@felixhaeberle felixhaeberle merged commit b3d0fdb into main Jun 25, 2024
5 checks passed
@felixhaeberle felixhaeberle deleted the felixhaeberle/sherl-2-cross-sell-ninja-in-sherlock branch June 25, 2024 14:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants