refactor recommendation packages

.changeset/cuddly-kangaroos-refuse.md

@@ -0,0 +1,10 @@
+---
+"@inlang/recommend-sherlock": minor
+"@inlang/recommend-ninja": minor
+"@inlang/paraglide-js": minor
+"vs-code-extension": minor
+---
+
+- renamed packages `@inlang/cross-sell-X` to `@inlang/recommend-X` be more descriptive
+- refactor recommendation view in Sherlock VS Code extension
+- introduce new `shouldRecommend` function to `@inlang/recommend-sherlock` & `@inlang/recommend-ninja` 

inlang/source-code/editor/package.json

@@ -68,7 +68,7 @@
 		"@iconify-json/cib": "^1.1.2",
 		"@iconify-json/material-symbols": "^1.1.26",
 		"@inlang/cli": "workspace:*",
-		"@inlang/cross-sell-ninja": "workspace:*",
+		"@inlang/recommend-ninja": "workspace:*",
 		"@inlang/design-system": "workspace:*",
 		"@inlang/detect-json-formatting": "workspace:*",
 		"@inlang/env-variables": "workspace:*",

inlang/source-code/editor/src/pages/@host/@owner/@repository/+Page.tsx

@@ -63,7 +63,7 @@ function TheActualPage() {
 		languageTags,
 		userIsCollaborator,
 		isNinjaRecommendationDisabled,
-		ninjaIsAdopted,
+		shouldRecommendNinja,
 		filteredMessageLintRules,
 		localChanges,
 	} = useEditorState()
@@ -183,7 +183,7 @@ function TheActualPage() {
 						<ListHeader />
 						<Show
 							when={
-								ninjaIsAdopted() === false &&
+								shouldRecommendNinja() === false &&
 								filteredMessageLintRules().length !== 0 &&
 								userIsCollaborator() &&
 								!isNinjaRecommendationDisabled()

inlang/source-code/editor/src/pages/@host/@owner/@repository/State.tsx

@@ -37,7 +37,7 @@ import {
 import { posthog as telemetryBrowser } from "posthog-js"
 import type { Result } from "@inlang/result"
 import { id } from "../../../../../marketplace-manifest.json"
-import * as Ninja from "@inlang/cross-sell-ninja"
+import * as Ninja from "@inlang/recommend-ninja"
 
 type EditorStateSchema = {
 	/**
@@ -147,7 +147,7 @@ type EditorStateSchema = {
 	languageTags: () => LanguageTag[]
 
 	isNinjaRecommendationDisabled: () => boolean
-	ninjaIsAdopted: Resource<boolean>
+	shouldRecommendNinja: Resource<boolean>
 	addNinja: (
 		triggerPushChanges: (message: string) => Promise<(() => void) | undefined>
 	) => Promise<void>
@@ -546,7 +546,7 @@ export function EditorStateProvider(props: { children: JSXElement }) {
 			(repo) => repo.owner === routeParams().owner && repo.repository === routeParams().repository
 		)
 
-	const [ninjaIsAdopted, { refetch: refetchNinjaIsAdopted }] = createResource(
+	const [shouldRecommendNinja, { refetch: refetchShouldRecommendNinja }] = createResource(
 		() => {
 			if (repo() === undefined || isNinjaRecommendationDisabled()) {
 				return undefined
@@ -556,17 +556,17 @@ export function EditorStateProvider(props: { children: JSXElement }) {
 		async ({ fs }) => {
 			// wait for the browser to be idle
 			await new Promise((resolve) => requestIdleCallback(resolve))
-			return await Ninja.isAdopted({ fs })
+			return await Ninja.shouldRecommend({ fs })
 		}
 	)
 
 	async function addNinja(
 		triggerPushChanges: (message: string) => Promise<(() => void) | undefined> | undefined
 	) {
 		try {
-			if (!ninjaIsAdopted() && repo()) {
+			if (!shouldRecommendNinja() && repo()) {
 				await Ninja.add({ fs: repo()!.nodeishFs })
-				refetchNinjaIsAdopted()
+				refetchShouldRecommendNinja()
 				// commit, push and pull
 				await triggerPushChanges("feat: add Ninja GitHub action 🥷")
 			}
@@ -789,7 +789,7 @@ export function EditorStateProvider(props: { children: JSXElement }) {
 					sourceLanguageTag,
 					languageTags,
 					isNinjaRecommendationDisabled,
-					ninjaIsAdopted,
+					shouldRecommendNinja,
 					addNinja,
 					tourStep,
 					setTourStep,

inlang/source-code/ide-extension/MARKETPLACE.md

@@ -1,5 +1,7 @@
 # 🕵️‍♂️ i18n inspector for VS Code
 
+[![Inlang-ecosystem compatibility badge](https://cdn.jsdelivr.net/gh/opral/monorepo@main/inlang/assets/md-badges/inlang.svg)](https://inlang.com)
+
 Inspect i18n within VS Code with powerful tools designed to streamline the translation process. Visualize, edit, and lint translated strings effortlessly using Inline Decorations & Hover Support. Extract new strings with a simple click, making localization tasks more intuitive and efficient.
 
 Find the [source code on GitHub](https://github.com/opral/monorepo/tree/main/inlang/source-code/ide-extension).

inlang/source-code/ide-extension/README.md

@@ -18,17 +18,16 @@ Visualize, edit, and lint translated strings effortlessly using Inline Decoratio
 	<br />
 </div>
 
-
 <img width="100%" src="https://cdn.jsdelivr.net/gh/opral/monorepo/inlang/source-code/ide-extension/assets/sherlock-cover-small.png"/>
 
 <br>
 <br>
 
-✅ Streamline the i18n translation process. 
+✅  Streamline the i18n translation process. 
 
-✅ Visualize, edit, and lint translations.
+✅  Visualize, edit, and lint translations.
 
-✅ Extract new translations with a simple click.
+✅  Extract new translations with a simple click.
 
 
 <br>