handshake

libs/visor_http_client/httpssession.cpp

@@ -343,8 +343,12 @@ void HTTPSSession::do_handshake()
         _tls_state = LinkState::DATA;
     } else {
         int error = SSL_get_error(_ssl_session, err);
-        if (error == SSL_ERROR_SSL || error == SSL_ERROR_SYSCALL) {
-            std::cerr << "Handshake failed: SSL or syscall error" << std::endl;
+        if (error == SSL_ERROR_SSL) {
+            std::cerr << "Handshake failed: SSL error" << std::endl;
+            ERR_print_errors_fp(stderr);
+            _handshake_error();
+        } else if (error == SSL_ERROR_SYSCALL) {
+            std::cerr << "Handshake failed: syscall error" << std::endl;
             ERR_print_errors_fp(stderr);
             _handshake_error();
         } else if (error == SSL_ERROR_WANT_READ || error == SSL_ERROR_WANT_WRITE) {

libs/visor_http_client/test_driver.cpp

@@ -164,16 +164,14 @@ TEST_CASE("HTTP Client", "[http]")
         // tcp_session->write(std::move(std::get<0>(qt)), std::get<1>(qt));
     };
 
-    tcp_session = std::make_shared<HTTPSSession>(tcp_handle, malformed_data, got_dns_message, connection_ready,
-        malformed_data, target_list[0], HTTPMethod::GET);
-    connect_tcp_events(tcp_handle, tcp_session);
-    auto client = std::make_shared<HTTPSSession>(tcp_handle,
-        nullptr,
-        nullptr,
-        nullptr,
-        nullptr,
+    tcp_session = std::make_shared<HTTPSSession>(tcp_handle,
+        malformed_data,
+        got_dns_message,
+        connection_ready,
+        malformed_data,
         target_list[0],
         HTTPMethod::GET);
+    connect_tcp_events(tcp_handle, tcp_session);
     if (!tcp_session->setup()) {
         std::cerr << "setup failed" << std::endl;
     }