Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lib http client #697

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Prev Previous commit
Next Next commit
fix segfault on osx
  • Loading branch information
weyrick committed Oct 20, 2023
commit 9866252229ee8f0110ce1766de303f46db70a11a
1 change: 1 addition & 0 deletions libs/visor_http_client/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ add_library(Visor::Lib::HttpClient ALIAS VisorLibHttpClient)
target_include_directories(VisorLibHttpClient
PUBLIC
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>
${CONAN_LIBS_LIBNGHTTP2}
)

target_link_libraries(VisorLibHttpClient
Expand Down
2 changes: 1 addition & 1 deletion libs/visor_http_client/httpssession.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ void HTTPSSession::do_handshake()
} else {
int error = SSL_get_error(_ssl_session, err);
if (error == SSL_ERROR_SSL || error == SSL_ERROR_SYSCALL) {
std::cerr << "Handshake failed: " << ERR_reason_error_string(error) << std::endl;
std::cerr << "Handshake failed: SSL or syscall error" << std::endl;
_handshake_error();
} else if (error == SSL_ERROR_WANT_READ || error == SSL_ERROR_WANT_WRITE) {
// Non-fatal error. OpenSSL wants to either read or write.
Expand Down
Loading