Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear sync status after renaming a resource to match excluded regex #7759

Open
HanaGemela opened this issue Feb 21, 2020 · 5 comments
Open
Assignees
Labels
feature:shell-extensions Overlay icons and context menu p3-medium Normal priority type:bug
Milestone

Comments

@HanaGemela
Copy link
Contributor

Client: 2.6.1 (build 13096)
Server: 10.4.0 RC4
macOS 10.15.3

Steps to recreate:

  1. Add 'excluded_directories_regex' => [ '.*pdf' ], in config.php on the server
  2. Open Finder -> go to ownCloud sync folder -> create a new folder
  3. Rename the folder to e.g. aaapdf
  4. Sync

Actual result: Folder has been renamed in Finder. Failed sync message shows the old name. Overlay icon is green - successfully synced. Selective sync list shows the old name. Confusing

Screenshot 2020-02-21 at 15 52 39

When a file in added in such folder, nothing happens. No message, no overlay icon...

Expected result: Either renamed everywhere and not synced, including red overlay icon or not renamed anywhere and still syncing, green overlay icon.

There is already a separate issue for the broken overlay icons #7703

@HanaGemela HanaGemela added type:bug p3-medium Normal priority feature:shell-extensions Overlay icons and context menu labels Feb 21, 2020
@HanaGemela HanaGemela added this to the 2.6.2 milestone Feb 21, 2020
@michaelstingl
Copy link
Contributor

@ogoffart anything we can improve here?

@ogoffart
Copy link
Contributor

It appears that the problem is that the destination of the move is not marked as a faillure as far as the socketapi is concerned.
That should be easy to fix

@HanaGemela
Copy link
Contributor Author

@ogoffart how exactly has this been fixed? What is the expected result?

Current behaviour: The overlay icon is red that's correct. But if I move the file into that folder, the file has a green icon and looks synced. But not synced in web ui

@TheOneRing
Copy link
Member

The bug is that the icon of that file is not updated.
If the page is refreshed the icon disappears as the whole folder is not tracked....

@michaelstingl
Copy link
Contributor

If the page is refreshed

What exactly do you refresh? Finder view?

@michaelstingl michaelstingl modified the milestones: 2.6.2, Backlog Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:shell-extensions Overlay icons and context menu p3-medium Normal priority type:bug
Projects
None yet
Development

No branches or pull requests

4 participants