SocketAPI: fix status after a failure to move #7822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
reviewed
Mar 25, 2020
| @@ -229,10 +229,10 @@ void SyncFileStatusTracker::slotAboutToPropagate(SyncFileItemVector &items) | |||
| _dirtyPaths.remove(item->destination()); | |||
|
|
|||
| if (hasErrorStatus(*item)) { | |||
| _syncProblems[item->_file] = SyncFileStatus::StatusError; | |||
| _syncProblems[item->destination()] = SyncFileStatus::StatusError; | |||
There was a problem hiding this comment.
Hm is that only an issue here or everywhere where _file is used?
There was a problem hiding this comment.
_file is usually the same as destination(), unless this is a move operation, then _file is the source.
But yes, in many case we want destination, while in some other case we want the source. Perhaps having a source() function to make it explicit and avoid the use of _file should be done.
TheOneRing
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7759