Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow displayname instead of display-name #8044

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

jnweiger
Copy link
Contributor

Seen in owncloud/product#181 (comment)
Please check which one is correct.

@TheOneRing
Copy link
Member

That indicates a server bug I guess.
@butonic

@butonic
Copy link
Member

butonic commented Sep 7, 2020

It is, but this would make the client a little more forgiving. Because the ocs endpoints in oc10 cannot even agree on how to spell things: owncloud/product#181 (comment)

The server would like to fix this and make it displayname everywhere ... but clients should allow that by checking both ... 🐔 🥚 problem ...

@TheOneRing
Copy link
Member

Ah ok

Copy link
Member

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please target 2.7

@jnweiger jnweiger changed the base branch from master to 2.7 September 8, 2020 12:38
@TheOneRing TheOneRing merged commit 2461530 into 2.7 Sep 8, 2020
@TheOneRing TheOneRing deleted the displayname-vs-display-name branch September 8, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants