OCS user endpoint uses wrong data type for booleans #181

C0rby · 2020-08-25T16:37:33Z

@jesmrec, tried to connect to https://ocis.owncloud.works using the Android App. The authentication process doesn't finish successfully and upon looking into the backend logs I found this:

2020-08-25T16:26:46Z DBG found account AccountEnabled=true CreatedDateTime=null DeletedDateTime=null Description= DisplayName="Reva Inter Operability Platform" GidNumber=15000 Id=bc596f3c-c955-4328-80a0-60d018b4ad57 Identities=null IsResourceAccount=false Mail=storage@example.org MemberOf=[{"id":"34f38767-c937-4eb6-b847-1c175829a2a0"}] OnPremisesDistinguishedName= OnPremisesLastSyncDateTime=null OnPremisesSamAccountName=reva OnPremisesSecurityIdentifier= OnPremisesSyncEnabled=false OnPremisesUserPrincipalName= PreferredName=reva UidNumber=10001 service=accounts
2020-08-25T16:26:46Z DBG Bind success binddn=cn=reva,ou=sysusers,dc=example,dc=org service=glauth src={"IP":"127.0.0.1","Port":54216,"Zone":""}
2020-08-25 16:26:46.963337 I | handleSearchRequest error LDAP Result Code 1 "Operations Error": LDAP Result Code 201 "": ldap: finished compiling filter with extra at end: (&(objectclass=posixAccount)(|(ownclouduuid=)(cn=)))
2020-08-25T16:26:46Z ERR srv/app/pkg/mod/github.com/cs3org/reva@v1.1.1-0.20200819100654-dcbf0c8ea187/internal/grpc/services/userprovider/userprovider.go:107 > error getting user error="userprovidersvc: error getting user: LDAP Result Code 1 \"Operations Error\": " pkg=rgrpc service=reva traceid=810b3455bb840d82f8ac975745281f54
2020-08-25T16:26:46Z INF unary code=OK end="25/Aug/2020:16:26:46 +0000" from=tcp://127.0.0.1:46362 pkg=rgrpc service=reva start="25/Aug/2020:16:26:46 +0000" time_ns=93856325 traceid=810b3455bb840d82f8ac975745281f54 uri=/cs3.identity.user.v1beta1.UserAPI/GetUser user-agent=grpc-go/1.26.0
{"level":"error","code":"\u000f","time":"2020-08-25T16:26:46.964588479Z","caller":"/srv/app/pkg/mod/github.com/cs3org/reva@v1.1.1-0.20200819100654-dcbf0c8ea187/pkg/storage/fs/owncloud/owncloud.go:542","message":"user lookup failed"}
2020-08-25T16:26:46Z ERR error getting owner error="user lookup failed" pkg=rgrpc service=reva traceid=810b3455bb840d82f8ac975745281f54

Is there a bug in the backend or does the Android App need some changes.

The text was updated successfully, but these errors were encountered:

butonic · 2020-08-25T16:47:20Z

basic auth or oidc? what user was used? the filter (&(objectclass=posixAccount)(|(ownclouduuid=)(cn=))) looks fishy. grep the log for 810b3455bb840d82f8ac975745281f54 and paste all lines.

C0rby · 2020-08-25T16:48:16Z

It was oidc and einstein.

C0rby · 2020-08-25T16:49:25Z

2020-08-25T16:26:46Z INF access token is already provided pkg=rhttp service=reva traceid=810b3455bb840d82f8ac975745281f54
2020-08-25T16:26:46Z DBG http routing head=remote.php pkg=rhttp service=reva tail=/dav/files traceid=810b3455bb840d82f8ac975745281f54
2020-08-25T16:26:46Z DBG skipping auth method=/cs3.gateway.v1beta1.GatewayAPI/Stat pkg=rgrpc service=reva traceid=810b3455bb840d82f8ac975745281f54
2020-08-25T16:26:46Z INF unary code=OK end="25/Aug/2020:16:26:46 +0000" from=tcp://127.0.0.1:40102 pkg=rgrpc service=reva start="25/Aug/2020:16:26:46 +0000" time_ns=253569 traceid=810b3455bb840d82f8ac975745281f54 uri=/cs3.storage.registry.v1beta1.RegistryAPI/GetStorageProvider user-agent=grpc-go/1.26.0
2020-08-25T16:26:46Z DBG ocfs: unwrap: internal= external=/ pkg=rgrpc service=reva traceid=810b3455bb840d82f8ac975745281f54
2020-08-25T16:26:46Z DBG ocfs: unwrap: internal= external=/ pkg=rgrpc service=reva traceid=810b3455bb840d82f8ac975745281f54
2020-08-25T16:26:46Z DBG skipping auth method=/cs3.identity.user.v1beta1.UserAPI/GetUser pkg=rgrpc service=reva traceid=810b3455bb840d82f8ac975745281f54
2020-08-25T16:26:46Z ERR srv/app/pkg/mod/github.com/cs3org/reva@v1.1.1-0.20200819100654-dcbf0c8ea187/internal/grpc/services/userprovider/userprovider.go:107 > error getting user error="userprovidersvc: error getting user: LDAP Result Code 1 \"Operations Error\": " pkg=rgrpc service=reva traceid=810b3455bb840d82f8ac975745281f54
2020-08-25T16:26:46Z INF unary code=OK end="25/Aug/2020:16:26:46 +0000" from=tcp://127.0.0.1:46362 pkg=rgrpc service=reva start="25/Aug/2020:16:26:46 +0000" time_ns=93856325 traceid=810b3455bb840d82f8ac975745281f54 uri=/cs3.identity.user.v1beta1.UserAPI/GetUser user-agent=grpc-go/1.26.0
2020-08-25T16:26:46Z ERR error getting owner error="user lookup failed" pkg=rgrpc service=reva traceid=810b3455bb840d82f8ac975745281f54
2020-08-25T16:26:46Z INF unary code=OK end="25/Aug/2020:16:26:46 +0000" from=tcp://127.0.0.1:52412 pkg=rgrpc service=reva start="25/Aug/2020:16:26:46 +0000" time_ns=97244681 traceid=810b3455bb840d82f8ac975745281f54 uri=/cs3.storage.provider.v1beta1.ProviderAPI/Stat user-agent=grpc-go/1.26.0
2020-08-25T16:26:46Z INF unary code=OK end="25/Aug/2020:16:26:46 +0000" from=tcp://127.0.0.1:40166 pkg=rgrpc service=reva start="25/Aug/2020:16:26:46 +0000" time_ns=100144974 traceid=810b3455bb840d82f8ac975745281f54 uri=/cs3.gateway.v1beta1.GatewayAPI/Stat user-agent=grpc-go/1.26.0
2020-08-25T16:26:46Z INF http end="25/Aug/2020:16:26:46 +0000" host=127.0.0.1 method=PROPFIND pkg=rhttp proto=HTTP/1.1 service=reva size=1018 start="25/Aug/2020:16:26:46 +0000" status=207 time_ns=103004182 traceid=810b3455bb840d82f8ac975745281f54 uri=/remote.php/dav/files/ url=/remote.php/dav/files/

C0rby · 2020-08-25T16:51:01Z

Some more info from Jesus.

There is no 4xx/5xx response. Both finish execution after requesting ocs/v2.php/cloud/user?format=json endpoint which response is more populated as in oC10 (f ex, contains quota information). iOS app shows as error Response was in unknown format (error 16).

jesmrec · 2020-08-25T17:10:10Z

Differences:

Container built some days ago (ocis version 2c4727d)

GET https://xxxx:9200/ocs/v2.php/cloud/user?format=json -> 200
Raw:
{"ocs":{"meta":{"status":"ok","statuscode":200,"message":"OK"},"data":{"id":"einstein","display-name":"Einstein","email":"einstein@example.org"}}}

Current ocis.owncloud.works

GET https://ocis.owncloud.works/ocs/v2.php/cloud/user?format=json -> 200

Json:

    "data": {
        "displayname": "Albert Einstein",
        "email": "einstein@example.org",
        "enabled": true,
        "gidnumber": 30000,
        "id": "4c510ada-c86b-4815-8820-42cdf82c3d51",
        "quota": {
            "definition": "default",
            "free": 2840756224000,
            "relative": 0.18,
            "total": 2845815640668,
            "used": 5059416668
        },
        "uidnumber": 20000,
        "username": "einstein"
    },
    "meta": {
        "message": "OK",
        "status": "ok",
        "statuscode": 200
    }
}```

jesmrec · 2020-08-25T17:17:00Z

I will add authorization info, just in case is useful as well

butonic · 2020-08-25T19:23:59Z

the output from ocis should now match the one from oc10:

curl https://ocis.owncloud.works/ocs/v1.php/cloud/users/4c510ada-c86b-4815-8820-42cdf82c3d51\?format\=json -u einstein | jq
{
  "meta": {
    "status": "ok",
    "statuscode": 100,
    "message": "OK"
  },
  "data": {
    "enabled": true,
    "id": "4c510ada-c86b-4815-8820-42cdf82c3d51",
    "username": "einstein",
    "displayname": "Albert Einstein",
    "email": "einstein@example.org",
    "quota": {
      "free": 2840756224000,
      "used": 5059416668,
      "total": 2845815640668,
      "relative": 0.18,
      "definition": "default"
    },
    "uidnumber": 20000,
    "gidnumber": 30000
  }
}

vs

curl https://demo.owncloud.com/ocs/v1.php/cloud/users/admin\?format\=json -u admin | jq
{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 100,
      "message": null
    },
    "data": {
      "enabled": "true",
      "quota": {
        "free": 25404542976,
        "used": 6784009,
        "total": 25411326985,
        "relative": 0.03,
        "definition": "default"
      },
      "email": null,
      "displayname": "admin",
      "home": "/var/lib/owncloud/files/admin",
      "two_factor_auth_enabled": "false"
    }
  }
}

yes uidnumber, gidnumber, id and username are new, but TCP is built on the robustness principle and it applies here as well. This is only additional data.

hmm

the "enabled" now is a bool instead of a string ... that might indeed kill the current parser that is tailored to parse the json ocs produces...

hm in reva we have an ocsBool:

type ocsBool bool

func (c *ocsBool) MarshalJSON() ([]byte, error) {
	if *c {
		return []byte("true"), nil
	}

	return []byte("false"), nil
}

func (c ocsBool) MarshalXML(e *xml.Encoder, start xml.StartElement) error {
	if c {
		return e.EncodeElement("1", start)
	}

	return e.EncodeElement("0", start)
}

let me check ocis-ocs which now implements the endpoint.

owncloud/ocis-ocs#39 now uses the truthy rendering, which should now return boolean true and false not strings in json and 0 and 1 in xml ... but I find it weird that oc10 returns a string for enabled ...

butonic · 2020-08-25T19:26:15Z

https://github.com/owncloud/core/blob/master/apps/provisioning_api/lib/Users.php#L205 😭

exalate-issue-sync · 2020-08-26T09:53:33Z

Vincent Petry commented: Set to p2

This is blocking testing efforts about TUS for mobile.

It can wait until the next sprint but would be good to have it early in the next sprint.

butonic · 2020-08-28T12:36:26Z

ocis.owncloud.works now returns this:

{
  "meta": {
    "status": "ok",
    "statuscode": 100,
    "message": "OK"
  },
  "data": {
    "enabled": "true",
    "id": "4c510ada-c86b-4815-8820-42cdf82c3d51",
    "username": "einstein",
    "displayname": "Albert Einstein",
    "email": "einstein@example.org",
    "quota": {
      "free": 2840756224000,
      "used": 5059416668,
      "total": 2845815640668,
      "relative": 0.18,
      "definition": "default"
    },
    "uidnumber": 20000,
    "gidnumber": 30000
  }
}

jesmrec · 2020-08-31T06:50:22Z

Unfortunately, clients still fail with this response. Checking out what's going on...

jesmrec · 2020-08-31T07:07:04Z

would it have to do that:

Before: { ocs { meta {...}, {data {...}}
Now: {meta {...}, {data {...}} -> ocs node is missing/removed.

??

checking...

@butonic @PVince81

Seen in owncloud/product#181 (comment) Please check which one is correct.

jesmrec · 2020-09-02T14:42:18Z

owncloud/ocis-ocs#47 did not fix. This is because another difference is there:

Before: display-name
Now: displayname

That makes Android not to finish the log on process and iOS finishes but display name is missing everywhere in the app

C0rby · 2020-09-02T14:52:50Z

I just noticed that the responses from /cloud/users/admin and /cloud/user differ....

curl https://demo.owncloud.com/ocs/v1.php/cloud/users/admin\?format\=json -u admin -s | jq
{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 100,
      "message": null
    },
    "data": {
      "enabled": "true",
      "quota": {
        "free": 25287991296,
        "used": 6784009,
        "total": 25294775305,
        "relative": 0.03,
        "definition": "default"
      },
      "email": null,
      "displayname": "admin",
      "home": "/var/lib/owncloud/files/admin",
      "two_factor_auth_enabled": "false"
    }
  }
}

displayname

curl https://demo.owncloud.com/ocs/v1.php/cloud/user\?format\=json -u admin -s | jq
{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 100,
      "message": "OK",
      "totalitems": "",
      "itemsperpage": ""
    },
    "data": {
      "id": "admin",
      "display-name": "admin",
      "email": null
    }
  }
}

display-name

This is awful... 😞

TheOneRing · 2020-09-07T09:32:37Z

Is displayname display-name the only issue that requires client changes?
We need to coordinate changes like this with all clients.

owncloud/client#8044

jesmrec · 2020-09-07T10:32:06Z

Should this be changed in clients? this is not very backwards compatible then...

TheOneRing · 2020-09-07T10:34:24Z

According to @butonic we should support both

Seen in owncloud/product#181 (comment) Please check which one is correct.

michaelstingl · 2020-09-09T16:06:14Z

Should this be changed in clients? this is not very backwards compatible then...

Just checked with @felixboehm and @micbar , different attribute names ("displayname" vs "display-name") is a bug and needs to be fixed in the backed. @TheOneRing you could revert the client change…

TheOneRing · 2020-09-09T16:07:25Z

So the server will not change the naming? and keep different spellings?

michaelstingl · 2020-09-09T16:13:15Z

So the server will not change the naming? and keep different spellings?

Backend needs to be fixed. Spelling will be same as oC 10. (ocs is legacy API and deprecated, so no need to introduce new structures…)

michaelstingl · 2020-09-15T20:36:09Z

I was checking with oC10 Docker, new iOS, current Android, and 2.7 desktop, they all use the same user endpoint:

GET /ocs/v2.php/cloud/user?format=json HTTP/1.1" 200 1266 "-" "ownCloudApp/11.4 (App/169; iOS/13.7; iPhone)

GET /ocs/v1.php/cloud/user?format=json HTTP/1.1" 200 854 "-" "Mozilla/5.0 (Macintosh) mirall/2.7.0 (build 2111) (ownCloud, osx-19.6.0 ClientArchitecture: x86_64 OsArchitecture: x86_64)

GET /ocs/v2.php/cloud/user?format=json HTTP/1.1" 200 854 "-" "Mozilla/5.0 (Android) ownCloud-android/2.15.2

% curl -u "admin:admin" "http://192.168.2.136:18080/ocs/v2.php/cloud/user?format=json" | jq
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   156  100   156    0     0   1695      0 --:--:-- --:--:-- --:--:--  1695
{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 200,
      "message": "OK",
      "totalitems": "",
      "itemsperpage": ""
    },
    "data": {
      "id": "admin",
      "display-name": "admin",
      "email": null
    }
  }
}

michaelstingl · 2020-09-15T20:41:56Z

iOS app and 2.7 desktop try the same with GET https://ocis.owncloud.works/ocs/v2.php/cloud/user?format=json

{
  "ocs": {
    "meta": {
      "status": "ok",
      "statuscode": 200,
      "message": "OK"
    },
    "data": {
      "enabled": "true",
      "id": "4c510ada-c86b-4815-8820-42cdf82c3d51",
      "username": "einstein",
      "displayname": "Albert Einstein",
      "email": "einstein@example.org",
      "quota": {
        "free": 2840756224000,
        "used": 5059416668,
        "total": 2845815640668,
        "relative": 0.18,
        "definition": "default"
      },
      "uidnumber": 20000,
      "gidnumber": 30000
    }
  }
}

	>
iOS 11.4 shows 4c510ada-c86b-4815-8820-42cdf82c3d51	Desktop 2.7 shows 4c510ada-c86b-4815-8820-42cdf82c3d51

michaelstingl · 2020-09-15T20:44:24Z

From client perspective, only /ocs/v2.php/cloud/user is sufficient, and it MUST contain display-name!!

C0rby · 2020-09-17T08:27:36Z

Connecting via the Android App works now.

exalate-issue-sync · 2020-10-21T00:12:58Z

Vincent Petry commented: Mobile team might have a workaround, but it might not be worth working around if fixing the issue is trivial.

[~dchristofas] are you able to quickly estimate the effort ? My gut feeling tells me that it might be a one liner.

cc [~mbarz]

exalate-issue-sync · 2020-10-21T00:13:11Z

Jörn Friedrich Dreyer commented: I'll work on this while waiting for builds to finish ...

jesmrec changed the title ~~Authentication via the Android app fails~~ Authentication via the mobile apps fails Aug 26, 2020

PVince81 changed the title ~~Authentication via the mobile apps fails~~ OCS user endpoint uses wrong data type for booleans Aug 26, 2020

PVince81 transferred this issue from owncloud/ocis Aug 26, 2020

exalate-issue-sync bot added the p2-high label Aug 26, 2020

butonic mentioned this issue Aug 26, 2020

Mimic oc10 user enabled as string in provisioning api owncloud/ocis-ocs#39

Merged

jesmrec mentioned this issue Aug 26, 2020

Resilient parsing of HTTP API responses in desktop and mobile clients #182

Closed

butonic closed this as completed in owncloud/ocis-ocs#39 Aug 26, 2020

jesmrec reopened this Aug 31, 2020

jnweiger added a commit to owncloud/client that referenced this issue Aug 31, 2020

allow displayname instead of display-name

51e41c4

Seen in owncloud/product#181 (comment) Please check which one is correct.

jnweiger mentioned this issue Aug 31, 2020

allow displayname instead of display-name owncloud/client#8044

Merged

C0rby mentioned this issue Sep 2, 2020

fix ocs resonse format owncloud/ocis-ocs#47

Merged

TheOneRing pushed a commit to owncloud/client that referenced this issue Sep 8, 2020

allow displayname instead of display-name

23f8e12

Seen in owncloud/product#181 (comment) Please check which one is correct.

TheOneRing pushed a commit to owncloud/client that referenced this issue Sep 8, 2020

allow displayname instead of display-name

2461530

Seen in owncloud/product#181 (comment) Please check which one is correct.

This was referenced Sep 9, 2020

Accept both display-name and displayname as nodes in user endpoint response owncloud/android#2954

Closed

Accept both display-name and displayname as nodes in user endpoint response owncloud/ios-app#796

Closed

TheOneRing mentioned this issue Sep 9, 2020

No display name owncloud/client#8068

Merged

C0rby mentioned this issue Sep 16, 2020

match the user responses to the OC10 format owncloud/ocis-ocs#61

Merged

C0rby closed this as completed Sep 17, 2020

exalate-issue-sync bot reopened this Oct 21, 2020

exalate-issue-sync bot added the bug Something isn't working label Oct 21, 2020

exalate-issue-sync bot closed this as completed Oct 21, 2020

huib-portainer mentioned this issue Nov 8, 2021

OAuth2 not working with Nextcloud portainer/portainer#3252

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCS user endpoint uses wrong data type for booleans #181

OCS user endpoint uses wrong data type for booleans #181

C0rby commented Aug 25, 2020

butonic commented Aug 25, 2020

C0rby commented Aug 25, 2020

C0rby commented Aug 25, 2020

C0rby commented Aug 25, 2020 •

edited

Loading

jesmrec commented Aug 25, 2020

jesmrec commented Aug 25, 2020

butonic commented Aug 25, 2020

butonic commented Aug 25, 2020

exalate-issue-sync bot commented Aug 26, 2020 •

edited

Loading

butonic commented Aug 28, 2020

jesmrec commented Aug 31, 2020

jesmrec commented Aug 31, 2020 •

edited

Loading

jesmrec commented Sep 2, 2020

C0rby commented Sep 2, 2020 •

edited

Loading

TheOneRing commented Sep 7, 2020 •

edited

Loading

jesmrec commented Sep 7, 2020

TheOneRing commented Sep 7, 2020

michaelstingl commented Sep 9, 2020 •

edited

Loading

TheOneRing commented Sep 9, 2020

michaelstingl commented Sep 9, 2020

michaelstingl commented Sep 15, 2020 •

edited

Loading

michaelstingl commented Sep 15, 2020

michaelstingl commented Sep 15, 2020 •

edited

Loading

C0rby commented Sep 17, 2020 •

edited

Loading

exalate-issue-sync bot commented Oct 21, 2020

exalate-issue-sync bot commented Oct 21, 2020

OCS user endpoint uses wrong data type for booleans #181

OCS user endpoint uses wrong data type for booleans #181

Comments

C0rby commented Aug 25, 2020

butonic commented Aug 25, 2020

C0rby commented Aug 25, 2020

C0rby commented Aug 25, 2020

C0rby commented Aug 25, 2020 • edited Loading

jesmrec commented Aug 25, 2020

jesmrec commented Aug 25, 2020

butonic commented Aug 25, 2020

butonic commented Aug 25, 2020

exalate-issue-sync bot commented Aug 26, 2020 • edited Loading

butonic commented Aug 28, 2020

jesmrec commented Aug 31, 2020

jesmrec commented Aug 31, 2020 • edited Loading

jesmrec commented Sep 2, 2020

C0rby commented Sep 2, 2020 • edited Loading

TheOneRing commented Sep 7, 2020 • edited Loading

jesmrec commented Sep 7, 2020

TheOneRing commented Sep 7, 2020

michaelstingl commented Sep 9, 2020 • edited Loading

TheOneRing commented Sep 9, 2020

michaelstingl commented Sep 9, 2020

michaelstingl commented Sep 15, 2020 • edited Loading

michaelstingl commented Sep 15, 2020

michaelstingl commented Sep 15, 2020 • edited Loading

C0rby commented Sep 17, 2020 • edited Loading

exalate-issue-sync bot commented Oct 21, 2020

exalate-issue-sync bot commented Oct 21, 2020

C0rby commented Aug 25, 2020 •

edited

Loading

exalate-issue-sync bot commented Aug 26, 2020 •

edited

Loading

jesmrec commented Aug 31, 2020 •

edited

Loading

C0rby commented Sep 2, 2020 •

edited

Loading

TheOneRing commented Sep 7, 2020 •

edited

Loading

michaelstingl commented Sep 9, 2020 •

edited

Loading

michaelstingl commented Sep 15, 2020 •

edited

Loading

michaelstingl commented Sep 15, 2020 •

edited

Loading

C0rby commented Sep 17, 2020 •

edited

Loading