Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Refactor apiShareReshare3 to use Shares folder #37918

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

haribhandari07
Copy link
Contributor

@haribhandari07 haribhandari07 commented Sep 18, 2020

Description

This PR makes apiShareReshare3 test scenarios to be valid in both oC10 and OCIS. OCIS always puts received shares into a folder called Shares for the share receiver. On OCIS, auto-accept shares is always disabled.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #37918 into master will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37918      +/-   ##
============================================
+ Coverage     64.44%   64.75%   +0.30%     
  Complexity    19408    19408              
============================================
  Files          1285     1285              
  Lines         75830    75830              
  Branches       1336     1336              
============================================
+ Hits          48868    49101     +233     
+ Misses        26568    26335     -233     
  Partials        394      394              
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <ø> (+0.34%) 19408.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
lib/private/Share/Share.php 71.05% <0.00%> (+0.06%) 504.00% <0.00%> (ø%)
apps/dav/lib/CalDAV/CalDavBackend.php 80.16% <0.00%> (+0.13%) 169.00% <0.00%> (ø%)
apps/dav/lib/CardDAV/CardDavBackend.php 82.57% <0.00%> (+0.22%) 85.00% <0.00%> (ø%)
lib/private/Files/View.php 83.36% <0.00%> (+0.29%) 391.00% <0.00%> (ø%)
lib/private/DB/Connection.php 67.64% <0.00%> (+0.73%) 49.00% <0.00%> (ø%)
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0.00%> (+0.96%) 68.00% <0.00%> (ø%)
lib/private/legacy/util.php 74.95% <0.00%> (+1.00%) 222.00% <0.00%> (ø%)
lib/private/DB/MDB2SchemaWriter.php 54.16% <0.00%> (+1.04%) 34.00% <0.00%> (ø%)
lib/private/legacy/db.php 71.79% <0.00%> (+1.28%) 33.00% <0.00%> (ø%)
lib/private/Files/Cache/Cache.php 97.64% <0.00%> (+1.76%) 107.00% <0.00%> (ø%)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dfd950...6d27806. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants