enable sharing tests

[individual-it]

• core API tests
• Phoenix UI tests

Questions to discuss:

1. in ocis every share needs to be accepted first, how should we deal with that in the tests
   1. make the step Given parameter "shareapi_auto_accept_share" of app "core" has been set to "yes" set some flag, so that the tests know to accept shares without it being mentioned in the Gherkin
   2. duplicate tests
2. in OCIS shares are accessible via the Shares folder.
   1. make the test be aware of that, so that it does not need to be mentioned in the Gherkin. But how to deal with when the tests check the existence of files/folders? The test code would have to know that this particular item is to be expected in the Shares folder or outside.
   2. add %SharesFolder% in front of every item that is expected to be a Share, in ocis-tests substitute that to Shares. This would not work for tests that expect the receiving item to ass (2) to the name if an item with the same name exists
   3. duplicate tests

CC @phil-davis @dpakach @PVince81 @kulmann

[phil-davis]

Also see owncloud/ocis-reva#415 - which is a more general issue to enable as many API test scenarios as "reasonable" so that they are run in CI, listed in expected-failures and "ready to be made to pass"

[phil-davis]

Note: PR owncloud/core#37774 did enable a small number tests that happened to pass.

[phil-davis]

core PR owncloud/core#37881 has the way forward for this. It creates new sharing scenarios that have share_folder set to Shares and auto-accept of shares off. That corresponds to the default OCIS settings. Those new scenarios run on both ownCloud10 and OCIS. See the PR for a detailed description of what is done with tags, scenario background, accepting received shares etc.

This issue can now be assigned to someone to do similar with the remaining sharing API tests.

[phil-davis]

I moved this to ToDo in Sprint 20-17 because there seems be no other sprint to choose.

[haribhandari07]

• apiShareReshare1 [Tests-Only] Refactor apiShareReshare1 to use Shares folder core#37916

• apiShareReshare2 [Tests-Only] Refactor reshare2 test suite to use root and share folder core#37919

• apiShareReshare3 [Tests-Only] Refactor apiShareReshare3 to use Shares folder core#37918

• apiShareManagementBasic [Tests-Only] Refactor createShareToShareFolder.feature to use Shares folder core#37881

• apiShareUpdate [Tests-Only] refactor updateShare suite for Shares subfolder and root core#37927

• apiShareNotifications [Tests-Only] Refactor apiShareNotifications to use Shares folder core#37928

• apiShareOperations [Tests-Only] refactor shareOperations test suite for Shares subfolder and root core#37930

• apiShareCreateSpecial1 [Tests-Only] Refactor apiShareCreateSpecial1 to use Shares folder core#37938

• apiShareCreateSpecial2 [Tests-Only] Refactor apiShareCreateSpecial2 to use Shares folder core#37929

• apiSharees (tests independent of share folder so skipped cc @phil-davis )

• apiShareManagement [Tests-Only] refactor shareManagement test suite for Shares subfolder and root core#37936

• apiFederation [Tests-Only] Refactor federation sharing tests for shares folder core#37967

Note: apiSharePublicLink1 and apiSharePublicLink2 do not need to be adjusted - those test scenarios do not depend on the setting of share_folder or the state of "auto-accept shares".

[phil-davis]

@haribhandari07 please also assign anyone else who is working on this.

[dpakach]

Phoenix WebUI Tests

• webUIResharing [Tests-Only] refactor tests for Shares folder: webuiResharing, webuiSharingAcceptShares web#4103
• webUIRestrictSharing [Tests-Only] Refactor restrict sharing and auto completion tests web#4108
• webUISharingAcceptShares [Tests-Only] refactor tests for Shares folder: webuiResharing, webuiSharingAcceptShares web#4103
• webUISharingAutocompletion [Tests-Only] Refactor restrict sharing and auto completion tests web#4108
• webUISharingExternal [Tests-Only] refactor federation sharing tests for shares folder web#4111
• webUISharingFilePermissionMultipleUsers [Tests-Only] refactor permission tests for shares folder web#4104
• webUISharingFilePermissionsGroups [Tests-Only] refactor permission tests for shares folder web#4104
• webUISharingFolderAdvancedPermissionMultipleUsers [Tests-Only] refactor permission tests for shares folder web#4104
• webUISharingFolderAdvancedPermissionsGroups [Tests-Only] refactor permission tests for shares folder web#4104
• webUISharingFolderPermissionMultipleUsers [Tests-Only] refactor permission tests for shares folder web#4104
• webUISharingFolderPermissionsGroups [Tests-Only] refactor permission tests for shares folder web#4104
• webUISharingInternalGroups [Tests-Only] refactor sharing with groups tests for shares folder web#4110
• webUISharingInternalUsers [Tests-Only] Refactor webUISharingInternalUsers to use Shares folder web#4114
• webUISharingNotifications [Tests-Only] Refactor webUISharingNotifications to use Shares folder web#4107
• webUISharingPermissionsUsers [Tests-Only] refactor permission tests for shares folder web#4104

[dpakach]

Webui tests to enable in CI

• webUIResharing [tests-only] Enable more sharing suites web#4195 [tests-only] add tests demonstrating issue-product-203 issue-ocis-717 web#4207
• webUIRestrictSharing [tests-only] Enable more sharing suites web#4195
• webUISharingAcceptShares [tests-only] Enable more sharing suites web#4195
• webUISharingAutocompletion [tests-only] add webUISharingAutocompletion to drone-CI web#4205
• webUISharingExternal [tests-only] fix Notification UI tests web#4212
• webUISharingFilePermissionMultipleUsers [tests-only] enable sharing permission tests web#4208
• webUISharingFilePermissionsGroups [tests-only] enable sharing permission tests web#4208
• webUISharingFolderAdvancedPermissionMultipleUsers [tests-only] enable sharing permission tests web#4208
• webUISharingFolderAdvancedPermissionsGroups [tests-only] enable sharing permission tests web#4208
• webUISharingFolderPermissionMultipleUsers [tests-only] enable sharing permission tests web#4208
• webUISharingFolderPermissionsGroups [tests-only] enable sharing permission tests web#4208
• webUISharingInternalGroups [tests-only] fix Notification UI tests web#4212
• webUISharingInternalUsers [CI] enable files sharing tests for ocis web#4161 [tests-only] add tests demonstrating issue-product-203 in shareWithUsers scenarios web#4209
• webUISharingNotifications [tests-only] fix Notification UI tests web#4212
• webUISharingPermissionsUsers [CI] enable files sharing tests for ocis web#4161 [tests-only] add tests demonstrating issue-product-203 in sharePermissionsUsers sc… web#4210
• webUISharingPublic [tests-only] run public link tests on OCIS in CI web#4222
• webUISharingPublicDifferentRoles [tests-only] run public link tests on OCIS in CI web#4222