Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] refactor updateShare suite for Shares subfolder and root #37927

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Sep 22, 2020

Description

Split apiShareUpdate test suite to 2 different test suites, one that uses the share folder and one in which shares are received in the root.

Related Issue

Motivation and Context

Receiving shares in the root folder is not available in ocis so this needs to be done so we can run the sharing tests in ocis.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #37927 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37927   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19442    19442           
=========================================
  Files          1286     1286           
  Lines         76020    76020           
  Branches       1336     1336           
=========================================
  Hits          49196    49196           
  Misses        26430    26430           
  Partials        394      394           
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <ø> (ø) 19442.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f049399...74651df. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants