Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Refactor apiShareCreateSpecial2 to use Shares folder #37929

Merged
merged 1 commit into from
Sep 24, 2020
Merged

[Tests-Only] Refactor apiShareCreateSpecial2 to use Shares folder #37929

merged 1 commit into from
Sep 24, 2020

Conversation

haribhandari07
Copy link
Contributor

@haribhandari07 haribhandari07 commented Sep 22, 2020 •
edited
Loading

Description

This PR makes apiShareCreateSpecial2 test scenarios to be valid in both oC10 and OCIS. OCIS always puts received shares into a folder called Shares for the share receiver. On OCIS, auto-accept shares is always disabled.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@haribhandari07 haribhandari07 marked this pull request as ready for review September 22, 2020 08:54
haribhandari07
haribhandari07 commented Sep 22, 2020
View reviewed changes
...ptance/features/apiShareCreateSpecialRoot2/createShareDefaultFolderForReceivedShares.feature Outdated
Scenario Outline: Do not allow sharing of the entire share_folder
Given using OCS API version "<ocs_api_version>"
And user "Brian" has been created with default attributes and without skeleton files
And the administrator has set the default folder for received shares to "<share_folder>"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phil-davis for this kind of case, do we need to run the scenario in ocis? If we are running, what will be the default folder for received share, /Shares/<share_folder> ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scenario can be deleted from here. Keep it in apiShareCreateSpecialShares2 suite.
In there, it needs to use share_folder /Shares (which is the usual value for the tests) and check to see what happens when Brian tries to share /Shares - that will be a valid test in both oC10 and OCIS.

@haribhandari07 haribhandari07 self-assigned this Sep 22, 2020
@codecov
Copy link

codecov bot commented Sep 22, 2020 •
edited
Loading

Codecov Report

Merging #37929 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37929   +/-   ##
=========================================
  Coverage     64.71%   64.71%           
  Complexity    19442    19442           
=========================================
  Files          1286     1286           
  Lines         76022    76022           
  Branches       1336     1336           
=========================================
  Hits          49196    49196           
  Misses        26432    26432           
  Partials        394      394
Flag Coverage Δ Complexity Δ
#javascript 54.06% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.88% <ø> (ø) 19442.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17aadf7...243fc57. Read the comment docs.

phil-davis
phil-davis reviewed Sep 24, 2020
View reviewed changes
...ptance/features/apiShareCreateSpecialRoot2/createShareDefaultFolderForReceivedShares.feature Outdated
Scenario Outline: Do not allow sharing of the entire share_folder
Given using OCS API version "<ocs_api_version>"
And user "Brian" has been created with default attributes and without skeleton files
And the administrator has set the default folder for received shares to "<share_folder>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scenario can be deleted from here. Keep it in apiShareCreateSpecialShares2 suite.
In there, it needs to use share_folder /Shares (which is the usual value for the tests) and check to see what happens when Brian tries to share /Shares - that will be a valid test in both oC10 and OCIS.

...acceptance/features/apiShareCreateSpecialShares2/createShareGroupAndUserWithSameName.feature Show resolved Hide resolved
@phil-davis phil-davis self-requested a review September 24, 2020 08:08
@phil-davis
Copy link
Contributor

Looks good - can be merged when drone CI passes.

@phil-davis phil-davis merged commit 76e705f into master Sep 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the refactor-shareCreateSpecial2 branch September 24, 2020 08:47
@haribhandari07 haribhandari07 mentioned this pull request Sep 25, 2020
Closed
2 tasks
@phil-davis phil-davis mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@dpakach dpakach Awaiting requested review from dpakach

Assignees

@haribhandari07 haribhandari07

Labels
4 - To release QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haribhandari07 @phil-davis