Import AppIcon from Figma #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hosy
approved these changes
Jun 21, 2019
tboerger
reviewed
Jun 24, 2019
| @@ -4,3 +4,6 @@ | |||
| [submodule "PocketSVG"] | |||
| path = external/PocketSVG | |||
| url = https://github.com/pocketsvg/PocketSVG.git | |||
| [submodule "external/PocketSVG"] | |||
There was a problem hiding this comment.
This submodule is listed twice now :)
There was a problem hiding this comment.
@tboerger good catch, thanks!
hosy
pushed a commit
that referenced
this pull request
Jun 24, 2019
* change version number 1.0 -> 1.0.1 * Fixed QA finding (1). "Share item" menu item was not visible, if item was not shared * Fix finding (3) * Fixed an issue with go-to button not being shown in PDF viewer (#403) * Fixed an issue with go-to button not being shown in PDF viewer * Added accessibility labels to bar button items in the PDF viewer * Version Bump to 121 * - Action class: - extend ActionWillRunHandler with a completionHandler and adding a new .perform() method to wrap .willRun() and .run(), allowing for actions to trigger view controller dismissals, wait for them to finish and then present their own view controllers - Card upgrades, improvement and fixes - fix MoreViewController "shaking" on initial presentation - create new CardPresentationSizing protocol to allow view controllers to provide sizing information to CardPresentationController - allow disabling the handle and the ability to dismiss by tapping in the background - create CardViewController as base class for future view controllers that should be presented as cards - Add new DownloadItemsHUDViewController class (a CardViewController subclass) to modally download files, provide a summary, allow cancellation and simplified retrieval of the corresponding OCFile objects - Clean up OpenInAction and rewrite most of it to use DownloadItemsHUDViewController - KVOWaiter allows waiting for an object's value to change, check if the change meets the criteria and then run a block once. Ended up not being used and is therefore not included in the builds. But since it may be useful in the future, left the source code regardless. - Add ProgressSummary.update(progressView:) convenience method * - Switch to release/1.0.1 branch for ios-sdk * - Add "Preparing" message to DownloadItemsHUDViewController while scheduling downloads - Update ios-sdk, fixing findings (5) + (6) * - Fix premature release of UIDocumentInteractionController in OpenInAction * - Add support for Progress.isCancelled to ProgressSummarizer * Version Bump to 122 * - Addressing (5) via SDK update rescheduling/retrying dropped requests * - Addressing (5) via SDK update rescheduling/retrying dropped requests * - Make File Provider use new SDK option to return immediately from a thumbnail request when offline * Version Bump to 123 * - Add new APP_SHORT_VERSION variable to build settings - Make Info.plist for app, File Provider and File Provider UI use it * - Fix remaining (5) issue for cases where the upload succeeded but the server response was cut off, prompting a retry and resulting in a "item already exists" error * - Update ios-sdk * QA finding (14) removed ownCloud name from localizable stings * [translation-sync] Translation sync (#359) * [tx] updated from transifex * Removed the es lang because was wrong and it is not necessary to map it (es -> es) (#310) * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * use newest SDK version * changed file encoding for localization files * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * - using correct SDK - solved encoding problems for localization files * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * using correct release SDK * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * [tx] updated from transifex * changed wrong file encoding from UTF-16LE to UTF-8 * removed ownCloud string in localizable strings * fixed merge conclicts * using newest release SDK * changed file encoding from UTF-16LE to UTF-8 * changed file encoding from UTF-16LE to UTF-8 * - removed deleting old log files, which is no longer needed in the release version, because we have now log rotation implemented - use newest SDK version * - fixed some localization strings - added missing localization string * - fixed german localization - added missing translation key * - only show action section, if not already exists - show created label, instead of invited label, if share was created by current user - fixed show keyboard * QA finding (16): share action on selecting table row * - added missing localization string - fixed wrong german localization string * QA finding 17, password text field was not shown, if password was set * linked against newest SDK * save the lock date into the keychain, which is needed for the file provider to decide, if file provider access should be locked, if pass code is enabled * Keeping “Browse” section always visible Allows to access logs even if logging is deactivated * Updated to use latest SDK version from 1.0.1 release branch * added an unlock bool, which is needed if we should show the authentication message in file provider or pass code view in app * Fixed QA finding (19): enable resharing for subitems, if sharing is allowed for root item * set unlocked value, if passcode was set/unset in settings * added some debug messages to debug pass code lock for file provider extension on bitrise build * - added some additional debug output * removed debug output and added new else if criteria * Fixed (20). Dissallowing to select placeholder items in the file list * changed translation key from "Always" to "Immediately" for pass code frequency * added debug logs for bitrise build (pass code testing in files app) * removed debug messages for file provider * added footer title for "Lock Application" settings, the display the user a explanation for the "Immediately" lock interval * Import AppIcon from Figma (#406) * Push 21 Figma assets via relay.graphics * Update Contents.json * added deleted submodules by relay commit * - Fix issue (20) via SDK fixes - Revert previous fix for (20) that had undesirable side effects for working offline * - Fix .gitmodules - Fix AppIcon pngs and run them through ImageOptim to save up to several MBs of space * - Switch SDK to release/1.0.1 commit on ios-sdk/master * - added new screens (#409) - changed steps to generate screenshots - added demo accounts - changed wording - new file names - added upload step to fastfile - updated fastlane * using tagged SDK from master * added changelog for released versions * CHANGELOG.md for 1.0.1 release (#407) * Added TestFlight builds to CHANGELOG.md * Release version 1.0.1 (June 2019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Figma > relay.graphics > michaelstingl/ios-app > owncloud/ios-app
Related Issue
#368
Motivation and Context
New Icon needed for the first App Store Release.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: