Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline mode #25

Open
6 of 7 tasks
jesmrec opened this issue Aug 7, 2018 · 7 comments
Open
6 of 7 tasks

Offline mode #25

jesmrec opened this issue Aug 7, 2018 · 7 comments

Comments

@jesmrec
Copy link

jesmrec commented Aug 7, 2018

The sdk is ready to perform actions when device is offline, and perform them once the app gets online mode again. Sometimes, such behaviour can lead to a lack of sync of other problems related. I will describe some of them here.

Also, discussions about expected behaviour can be handled here

NOTE: Some of the issues can concern the app (@pablocarmu). They are reported here, so the offline mode is manly responsibility of the SDK.


@jesmrec
Copy link
Author

jesmrec commented Aug 7, 2018

(1) [FIXED]

App crashes by performing these steps:

  1. Go offline (plane mode)
  2. Delete a file -> file is not deleted, but a notification appears on the bottom
  3. Perform the same action in 2. (Delete the same file again)
  4. Go online -> Alert shown about changes in the file in server
  5. Delete any content

Current: App crashes and no more content can be deleted.
Expected: Alert in 4. is not correct. All content correctly deleted.

@jesmrec
Copy link
Author

jesmrec commented Aug 7, 2018

(2)

Same action in server and app when app is online causes a conflict that the user has to fix. The action in the app is ignored:

  1. Go offline in the app
  2. In webUI, rename a item
  3. In app, rename the same item with a different name
  4. Go online

Current: The app shows an alert: "item not found". List is not refreshed automatically. When pulling down, the change in the webUI is fetched and updated, and the change in the app is ignored

Expected: User is asked for the version to keep.

@jesmrec
Copy link
Author

jesmrec commented Aug 7, 2018

(3) [FIXED]

owncloud/ios-app#102 (comment)

the operations seem to be queued. When the first one is executed (renamed), the source file does not have the same name, so the second action will not find such file.

@jesmrec
Copy link
Author

jesmrec commented Sep 26, 2018

(4) [FIXED]

  1. Go offline
  2. Drag&Drop a folder to another location (move)
  3. Repeat the same action (same source folder and same location) several times
  4. Go online

Current: action is performed once, correctly. Next time one item is moved (no matter which one), an error appears pointing to the actions that were not executed in offline mode. Error will be raised as many times as "move" actions were done.

Expected/Suggested: in offline mode, if the same operation (exactly the same) is performed more than one time in a row, it should be discarded to avoid such side-effects.

NOTE: Same effect with Duplicate action

@jesmrec
Copy link
Author

jesmrec commented Nov 21, 2018

(5) [FIXED]

files app related, rename items offline:

owncloud/ios-app#67 (comment)

@jesmrec
Copy link
Author

jesmrec commented Nov 28, 2018

(6) [FIXED]

Upload a file from photo library with no connection. From owncloud/ios-app#146 (comment)

@jesmrec
Copy link
Author

jesmrec commented Nov 28, 2018

(7) [FIXED]

Upload a file, and connection is lost in the middle, pointing to an error even though the upload success.

From owncloud/ios-app#146 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant