This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
Role select ui #89
Merged
Role select ui #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
force-pushed
the
add-permissions-for-roles
branch
from
c5da550
to
e695ccc
Compare
kulmann
force-pushed
the
role-select-ui
branch
from
9461b18
to
5657532
Compare
kulmann
force-pushed
the
role-select-ui
branch
from
c9812a8
to
f45a1ab
Compare
|
rebased on #90, let's see what happens |
kulmann
force-pushed
the
role-select-ui
branch
from
8109037
to
9f3c347
Compare
The assignments are now removed through the server. No need to do this via JS anymore
kulmann
force-pushed
the
role-select-ui
branch
from
9f3c347
to
60957d9
Compare
PVince81
suggested changes
Aug 21, 2020
| this.getUsersCurrentRole() | ||
| } else { | ||
| this.showMessage({ | ||
| title: 'Failed to change role.', |
| }) | ||
|
|
||
| if (response.status === 201) { | ||
| this.getUsersCurrentRole() |
There was a problem hiding this comment.
use response body for populating
| commit('SET_ROLES', roles || []) | ||
| } else { | ||
| dispatch('showMessage', { | ||
| title: 'Failed to fetch roles.', |
There was a problem hiding this comment.
didn't fix. apparently it's not that easy to access $gettext in vuex store, since it has no access to the Vue instance. Raised this ticket instead, since we are using $gettext in a wrong way: owncloud/web#3984
| @@ -11,3 +11,11 @@ Then('user {string} should be displayed in the accounts list on the WebUI', asyn | |||
| const userListed = await client.page.accountsPage().isUserListed(username) | |||
| return assert.strictEqual(userListed, username) | |||
| }) | |||
|
|
|||
| When('the users changes the role of user {string} to {string} using the WebUI', function (username, role) { | |||
Previously we were fetching the role assignments again. Not necessary, as the request for setting a role already returns the resulting assignment object as a response.
Apparently the step definition for the page reload gets reused from phoenix.
|
Complexity increasing per file
==============================
- ui/helpers/utils.js 2
- ui/helpers/auth.js 3
Complexity decreasing per file
==============================
+ ui/store/index.js -1
Clones added
============
- ui/client/settings/index.js 84
See the complete overview on Codacy |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #54
Todo: