Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Adapt settings bundle to new data model #54

Closed
wants to merge 20 commits into from

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 10, 2020

DO NOT MERGE. This is work in progress.

Data model for settings and settings bundles has changed. This PR adapts settings bundles in ocis-accounts to the most recent version. Until ocis-settings is released, you have to checkout owncloud/ocis-settings#35 locally and make a local replace in go.mod.

@update-docs
Copy link

update-docs bot commented Jul 10, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Jul 10, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell C 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann force-pushed the adapt-settings-bundle-model branch 2 times, most recently from 89c99c2 to 84d75a7 Compare July 10, 2020 16:01
@refs
Copy link
Member

refs commented Jul 20, 2020

bug: with this changes, starting the ocis-accounts service without the ocis-settings blows up:

go run cmd/ocis-accounts/main.go server
2020-07-20T16:52:36+02:00 INF Starting server addr=0.0.0.0:9181 service=accounts transport=http
2020-07-20T16:52:36+02:00 INF Starting server addr=0.0.0.0:9180 service=accounts transport=grpc
2020-07-20T16:52:37+02:00 INF Reporting settings bundles to settings service service=com.owncloud.api.accounts
2020-07-20 16:52:37  file=service.go:206 level=info Starting [service] com.owncloud.api.accounts
2020-07-20 16:52:37  file=grpc.go:845 level=info Server [grpc] Listening on [::]:9180
2020-07-20 16:52:37  file=service.go:239 level=info Listening on [::]:9181
2020-07-20 16:52:37  file=grpc.go:676 level=info Registry [mdns] Registering node: com.owncloud.api.accounts-4e32790c-0b1e-4fbd-8b17-2297b3f61aa1
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x49f1b8c]

goroutine 56 [running]:
github.com/owncloud/ocis-accounts/pkg/service/v0.RegisterSettingsBundles(0xc000402a80)
        /Users/aunger/code/owncloud/ocis-accounts/pkg/service/v0/settings.go:29 +0x3dc
created by github.com/owncloud/ocis-accounts/pkg/command.Server.func2.2
        /Users/aunger/code/owncloud/ocis-accounts/pkg/command/server.go:77 +0xd4
exit status 2

@LukasHirt LukasHirt self-assigned this Jul 31, 2020
@LukasHirt
Copy link
Contributor

Basic UI done. Just need to find a nice way to use the swagger generated APIs from settings instead of fetch.

image
image

@kulmann kulmann force-pushed the adapt-settings-bundle-model branch from e6d603c to 08fe437 Compare August 14, 2020 09:01
@ownclouders
Copy link

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- ui/helpers/auth.js  3
- ui/helpers/utils.js  2
- pkg/service/v0/settings.go  2
         

Complexity decreasing per file
==============================
+ ui/store/index.js  -1
         

Clones added
============
- ui/client/settings/index.js  84
- pkg/service/v0/settings.go  5
         

See the complete overview on Codacy

@kulmann kulmann mentioned this pull request Aug 19, 2020
2 tasks
@kulmann
Copy link
Member Author

kulmann commented Aug 19, 2020

Superseded by #87, #88 and #89

@kulmann kulmann closed this Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants