This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Adapt settings bundle to new data model #54
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
28 tasks
kulmann
force-pushed
the
adapt-settings-bundle-model
branch
2 times, most recently
from
July 10, 2020 16:01
89c99c2
to
84d75a7
Compare
bug: with this changes, starting the ocis-accounts service without the ocis-settings blows up:
|
kulmann
commented
Aug 2, 2020
The assignments are now removed through the server. No need to do this via JS anymore
The previous code was creating nil dereferencing in case of errors, since it was trying to read an Id from the response of a failed request.
kulmann
force-pushed
the
adapt-settings-bundle-model
branch
from
August 14, 2020 09:01
e6d603c
to
08fe437
Compare
Here is an overview of what got changed by this pull request: Complexity increasing per file
==============================
- ui/helpers/auth.js 3
- ui/helpers/utils.js 2
- pkg/service/v0/settings.go 2
Complexity decreasing per file
==============================
+ ui/store/index.js -1
Clones added
============
- ui/client/settings/index.js 84
- pkg/service/v0/settings.go 5
See the complete overview on Codacy |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. This is work in progress.
Data model for settings and settings bundles has changed. This PR adapts settings bundles in ocis-accounts to the most recent version. Until ocis-settings is released, you have to checkout owncloud/ocis-settings#35 locally and make a local replace in
go.mod
.