Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

[Tracing]: Start root span on Proxy #64

Merged
merged 4 commits into from
Jul 9, 2020
Merged

[Tracing]: Start root span on Proxy #64

merged 4 commits into from
Jul 9, 2020

Conversation

refs
Copy link
Member

@refs refs commented Jul 9, 2020

We use an HTTP propagator to go beyond our process boundary. Essentially the span gets serialized in the request context and travels along with the HTTP request. You can test this changes by starting the ocis set of services:

ocis server

stop the proxy: ocis kill proxy
start a new proxy process with the changes from this PR:

# on the root of this repository, on this PR branch
go run cmd/ocis-proxy/main.go --log-level debug server --tracing-enabled=true

Start jaeger default container:

docker run -d --name jaeger \
  -e COLLECTOR_ZIPKIN_HTTP_PORT=9411 \
  -p 5775:5775/udp \
  -p 6831:6831/udp \
  -p 6832:6832/udp \
  -p 5778:5778 \
  -p 16686:16686 \
  -p 14268:14268 \
  -p 14250:14250 \
  -p 9411:9411 \
  jaegertracing/all-in-one:1.18

on the browser: https://localhost:9200, sign in, do some actions.
go to: http://localhost:16686
on the far left, the Service dropdown select proxy
see some traces.

@update-docs
Copy link

update-docs bot commented Jul 9, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs refs requested a review from butonic July 9, 2020 12:22
@refs refs mentioned this pull request Jul 9, 2020
@refs refs self-assigned this Jul 9, 2020
@ownclouders
Copy link

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- pkg/proxy/proxy.go  1
         

See the complete overview on Codacy

@butonic butonic merged commit 99dc6b2 into master Jul 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature-tracing branch July 9, 2020 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants