This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Closed
IljaN
approved these changes
Mar 18, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@refs needs a rebase |
Here is an overview of what got changed by this pull request: Complexity increasing per file
==============================
- pkg/command/server.go 1
See the complete overview on Codacy |
@refs can you rebase? we want to add jaeger to the docker compose. the proxy should show up ... |
rebasing was a headache. Redoing the branch was easier. Closing in favor of #64 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch creates a root trace, sends it over the wire for every other service to add spans.
Start the service with tracing enable:
Start
ocis-konnectd
as explained here: owncloud/ocis-konnectd#47go to
https://localhost:9200/signin/v1/identifier
go to
http://localhost:16686/
select the
proxy
service from the service dropdownclick on
find traces
That set of steps should end in something like this:
and by clicking on a trace, more details are displayed: