Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

[WIP] Tracing #9

Closed
wants to merge 6 commits into from
Closed

[WIP] Tracing #9

wants to merge 6 commits into from

Conversation

refs
Copy link
Member

@refs refs commented Mar 9, 2020

This branch creates a root trace, sends it over the wire for every other service to add spans.

Start the service with tracing enable:

go run cmd/ocis-proxy/main.go \
--config-file ./config/.proxy-example.json server \
--tracing-enabled \
--tracing-type jaeger \
--tracing-collector http://localhost:14268/api/traces

Start ocis-konnectd as explained here: owncloud/ocis-konnectd#47

go to https://localhost:9200/signin/v1/identifier
go to http://localhost:16686/
select the proxy service from the service dropdown
click on find traces

That set of steps should end in something like this:

image

and by clicking on a trace, more details are displayed:

image

@update-docs
Copy link

update-docs bot commented Mar 9, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@refs refs self-assigned this Mar 9, 2020
@refs refs changed the title add tracing to the proxy service Tracing Mar 9, 2020
@refs refs requested a review from butonic March 10, 2020 10:18
@butonic butonic mentioned this pull request Mar 13, 2020
Copy link
Member

@IljaN IljaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@micbar
Copy link
Contributor

micbar commented Apr 7, 2020

@refs needs a rebase

@micbar micbar added the enhancement New feature or request label Apr 7, 2020
@ownclouders
Copy link

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- pkg/command/server.go  1
         

See the complete overview on Codacy

@refs refs changed the title Tracing [WIP] Tracing Jun 2, 2020
@butonic
Copy link
Member

butonic commented Jul 9, 2020

@refs can you rebase? we want to add jaeger to the docker compose. the proxy should show up ...

@refs
Copy link
Member Author

refs commented Jul 9, 2020

rebasing was a headache. Redoing the branch was easier. Closing in favor of #64

@refs refs closed this Jul 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants