This repository has been archived by the owner on Jan 27, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs
reviewed
Jul 7, 2020
@kulmann made some changes to align the mount path for the settings and as a result got the following tree:
The nested |
With my patch now the folder structure is:
Testing to check the core functionality doesn't break. |
As tracked in #32 we want to have consistent naming for the identifier fields. This is better now.
- a SettingsBundle is about a resource. One type of resource is the system itself. - a Setting is about a resource as well. In this, a SettingsBundle could be about a group and settings about specific resources (e.g. files or users) of that group. - PermissionSettings exist for allowing an operation on the given resource.
- bundles are now stored in a path depending on the resource provided with the settings bundle request (list/get/save) - added basic unit tests (still without assertions) from @refs Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz> Co-authored-by: Alex Unger <zyxancf@gmail.com>"
Added two new endpoints for SettingsBundle management to our protobuf definition: - AddSettingToSettingsBundle - RemoveSettingFromSettingsBundle
We were using triple-identifiers for settings (extension-name, bundle-key, setting-key) and tuple-identifiers for bundles (extension-name, bundle-key). As it turns out this is not working out well for referencing e.g. settings from within other settings, which is required for adding permissions as settings. Thus we changed our protobuf definition to have uuids insteads of complex identifiers. Along with changing to identifiers we needed to rewrite our persistence implementation. GRPC tests are broken and will be fixed in one of the next commits.
Reason for this is, that writing the empty role definition again would remove all settings / permissions that were already added to the role by external services.
At the moment the permissions check statically returns true (next step for the implementation), so this just wires everything to have a permission check in place.
Refactored constraints.
It is needed in frontend code to walk settings by their names. Not very developer-friendly to require the knowledge of the correct UUID for a setting.
…ings into roles-and-permissions
1 task
Merged
Merged
For the record, we moved the code into four separate PRs: |
Tracked account uuid validation here https://github.com/owncloud/ocis-settings/issues/50 |
this entire PR was split into multiple other PRs and is not needed anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work In Progress 🚧
Implementation for owncloud/product#85
Also fixes #32
Required cleanup before review/merge:
path
withfilepath
SYSTEM
)Create and merge pull requests for adapting to the new data model and using the new roles & permissions system in
identifier
identifier