[CI] enable nightly test runs

[dpakach]

Fixes #895

Enable nightly test runs in CI.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

[phil-davis]

LGTM. We will only really know after merging.

@dpakach after I merge this, please

• do a PR with [docs-only] to verify that it works as expected.
• do a [tests-only] PR for something small, and we can verify that all pipelines run as expected in the CI of the PR
• then merge something and see what happens to both the merge CI and the cron CI

[wkloucek]

I'm having problems with this line: if ctx.build.cron != "": It prevents me to convert the starlark to yml. Is there a reason you didn't use if ctx.build.event == "cron": ?

[phil-davis]

We found a post where the build.cron attribute was "documented". https://discourse.drone.io/t/starlark-context-not-have-some-detailed-info/6087/2

The source code https://github.com/drone/drone-convert-starlark/blob/master/plugin/args.go has cron as one of the attributes, and it should be a starlark.String

I guess drone is a nerd-project - the source code is the documentation.

But locally I get the error:

$ drone starlark
2020/11/23 15:06:05 "build" struct has no .cron attribute

I guess my local drone does not have the current drone-convert-starlark

[dpakach]

@phil-davis seems like only these attributes are available when converting

"context"(build = "build"(branch = "master", commit = "", event = "push", message = "", ref = "refs/heads/master", source = "", target = ""), repo = "repo"(name = "", namespace = "", slug = ""))

[dpakach]

@wkloucek, I think in this case your approach works better,
Please review this PR #923

[wkloucek]

Yeah, finding reliable information on drone is really cumbersome. The main issue for me is, that I can not convert to yml anymore.

Are you ok with using if ctx.build.event == "cron": as long as we don't specify cron names? It think this is what the build.cron should contain!?

We also could make a PR to @micbar because he is already "maintaining" a working drone cli micbar/drone-cli@f0e9e08

[phil-davis]

After installing the latest drone-cli:

$ curl -L https://github.com/drone/drone-cli/releases/latest/download/drone_linux_amd64.tar.gz | tar zx
$ sudo install -t /usr/local/bin drone
$ drone --version
drone version 1.2.4

I get:

$ drone starlark
2020/11/23 15:21:10 starlark evaluation error:
Traceback (most recent call last):
  .drone.star:201:15: in main
Error: "build" struct has no .cron attribute

So at least the error message has more information.

I wonder how I install the latest drone-convert-starlark as a plugin to drone-cli?

[phil-davis]

https://github.com/drone/drone-cli/blob/master/drone/starlark/starlark.go

There is "starlark" knowledge built-in to the drone-cli repo. And that only has a subset of the ctx attributes that are available in the extension. Code-duplication - I guess the drone-cli stuff could have the other attributes added and maybe they will "just work".

[micbar]

see harness/drone-cli#175

[phil-davis]

Also note for future readers.
https://github.com/owncloud/activity/blob/master/.drone.star#L969

								if (params['cron'] == ''):
									result['trigger']['ref'] = [
										'refs/pull/**',
										'refs/tags/**'
									]
									for branch in config['branches']:
										result['trigger']['ref'].append('refs/heads/%s' % branch)
								else:
									result['trigger']['cron'] = params['cron']

We have starlark code that allows pipelines to trigger on a specific "cron" value. At the moment the relevant repos just have a "nightly" cron job. And the starlark correctly generates pipelines that run only nightly - they do not run with every PR.

So that stuff does work on the drone server, and we could potentially have some special tests that run only for cron "weekly" etc.

That parses OK with local drone starlark and includes pipelines that have a section like:

trigger:
  cron:
  - nightly

So the local drone-cli know enough to allow that (or doesn't try hard enough to parse it)