Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [CI] fix the nightly builds pipelines #923

Merged
merged 1 commit into from
Nov 23, 2020
Merged

[tests-only] [CI] fix the nightly builds pipelines #923

merged 1 commit into from
Nov 23, 2020

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Nov 23, 2020 •
edited
Loading

Fix the cron build cases in drone.starlark.

phil-davis
phil-davis approved these changes Nov 23, 2020
View reviewed changes
.drone.star Outdated Show resolved Hide resolved
@phil-davis phil-davis changed the title [CI] fix the nightly builds pipelines [tests-only] [CI] fix the nightly builds pipelines Nov 23, 2020
@owncloud owncloud deleted a comment from update-docs bot Nov 23, 2020
@dpakach dpakach marked this pull request as ready for review November 23, 2020 09:34
@dpakach dpakach mentioned this pull request Nov 23, 2020
Merged
@phil-davis
Copy link
Contributor

Can we put a link in this PR to somewhere in drone source code where the known valid string values of ctx.build.event are visible (source code, or documentation). Otherwise it is all magic.

@wkloucek
Copy link
Contributor

see https://docs.drone.io/pipeline/triggers/ -> By Event

trigger:
  event:
  - cron
  - custom
  - push
  - pull_request
  - tag
  - promote
  - rollback

@phil-davis
Copy link
Contributor

Rebased - let's see if we can get green CI now, after other .drone.star changes were also merged in the last hours.

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit edcb61f into master Nov 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-nightly branch November 23, 2020 16:02
ownclouders pushed a commit that referenced this pull request Nov 23, 2020
@phil-davis
commit edcb61f
6d83031 
Merge: bdb04a3 6002398
Author: Phil Davis <phil@jankaritech.com>
Date:   Mon Nov 23 21:47:45 2020 +0545

    Merge pull request #923 from owncloud/fix-nightly

    [tests-only] [CI] fix the nightly builds pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@wkloucek wkloucek wkloucek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpakach @phil-davis @wkloucek