fix(view rendering): cancel overlapping resource requests #5917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linter is not happy. ;-) Tested it locally and wasn't able to break it. 🚀 |
kulmann
reviewed
Oct 17, 2021
introduce iterable generators using vue-concurrency to cancel resource request that no longer needed. Fixes wrong view rendering for long running requests
fschade
force-pushed
the
generator-concurrency
branch
from
c01974c
to
b24fab0
Compare
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing the files app with heavy load we've found some cases where it could happen that the ui breaks or displays wrong list of files, this only happened when navigation fast between the different views.
To dig a bit deeper we've used the mounted and created hooks to load current views resources for files app, which can lead to overlapping rendering when view
Astill prepares the resource data and the user quickly switches to viewB. If thenBis rendered beforeAis finished vue renders the viewAintoB.This is an overall problem and is present in many projects, where state, data and timing overlaps. This potentially is a memory leak also, in cases where
thisis used and the instance isn't around anymore.This PR fixes those cases for the files app by superseding the usual vue behavior and use iterable generators from vue-concurrency and cancel the preparation step (request loading, state loading, view rendering) when not needed anymore.
Related Issue
Motivation and Context
get a fast and concurrency safe ui
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: