[Tests-Only] refactor permission tests for shares folder #4104

dpakach · 2020-09-24T13:21:47Z

Description

Refactor webui test scenarios for using the Shares folder and root folder for shares.

Related Issue

Related enable sharing tests ocis#518

Motivation and Context

Shares in ocis are received in Shares folder by default. To test that we need this refactor.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

...

dpakach · 2020-09-25T11:13:19Z

@phil-davis I have added all permission tests on the root folder to one suite and removed all scenario outlines. So there is only one test for each condition. These suites check the different combinations of permissions. So I thought it was wise not to run those 2 times. The tests for Shares folder runs all the combination so that we can run them on ocis and oc10 both.

individual-it

need to solve this discussion #4103 (comment)

two points in the discussion:

creating a new When step with using the API
moving the "accept" steps up to the other Whens

phil-davis · 2020-09-29T11:15:32Z

tests/acceptance/features/webUISharingFolderPermissionsGroups/sharePermissionsGroup.feature

    Then custom permissions "<displayed-permissions>" should be set for user "grp2" for folder "simple-folder" on the webUI
    And custom permissions "<displayed-permissions>" should be set for user "User Three" for folder "simple-folder" on the webUI
    And group "grp2" should be listed as "<displayed-role>" in the collaborators list for folder "simple-folder" on the webUI
    And user "User Three" should be listed as "<displayed-role>" in the collaborators list for folder "simple-folder" on the webUI
-    And user "user2" should have received a share with these details:
+    Then user "user2" should have received a share with these details:


Suggested change

Then user "user2" should have received a share with these details:

And user "user2" should have received a share with these details:

But not a big deal.

phil-davis · 2020-09-29T11:18:54Z

tests/acceptance/features/webUISharingPermissionToRoot/shareAdvancePermissionsGroup.feature

+    And as "user1" folder "simple-folder (2)" should not exist
+    Examples:
+      | role                 | displayed-role          | extra-permissions             | displayed-permissions | actual-permissions           |
+      # | Advanced permissions | Advanced permissions    | delete                        | delete                | read, delete                 |


Note: the detailed combinations of permissions are being done in webUISharingFolderAdvancedPermissionsGroups/shareAdvancePermissionsGroup.feature which also has the share_folder set to Shares - that is OK.

phil-davis · 2020-09-29T11:19:49Z

tests/acceptance/features/webUISharingPermissionToRoot/shareFileWithMultipleUsers.feature

+    And as "user4" file "lorem(2).txt" should not exist
+    Examples:
+      | role                 | displayed-role | extra-permissions | displayed-permissions | actual-permissions  |
+      # | Viewer               | Viewer         | share             | share                 | read, share         |


Note: the detailed example cases are now done in the suite that has share_folder set to Shares, so they can run on OCIS.

phil-davis · 2020-09-29T11:20:16Z

tests/acceptance/features/webUISharingPermissionToRoot/shareFolderWithMultipleUsers.feature

+    And as "user4" folder "simple-folder (2)" should not exist
+    Examples:
+      | role                 | displayed-role          | extra-permissions             | displayed-permissions | actual-permissions           |
+      # | Viewer               | Viewer                  | share                         | share                 | read, share                  |


Note: the detailed example cases are now done in the suite that has share_folder set to Shares, so they can run on OCIS.

phil-davis · 2020-09-29T11:20:28Z

tests/acceptance/features/webUISharingPermissionToRoot/sharePermissionsFileGroup.feature

+    And as "user1" file "lorem (2).txt" should not exist
+    Examples:
+    | role                 | displayed-role | extra-permissions | displayed-permissions | actual-permissions  |
+    # | Viewer               | Viewer         | share             | share                 | read, share         |


Note: the detailed example cases are now done in the suite that has share_folder set to Shares, so they can run on OCIS.

phil-davis · 2020-09-29T11:20:50Z

tests/acceptance/features/webUISharingPermissionToRoot/sharePermissionsFoldersGroup.feature

+    And as "user1" folder "simple-folder (2)" should not exist
+    Examples:
+    | role                 | displayed-role          | extra-permissions             | displayed-permissions | actual-permissions           |
+    # | Viewer               | Viewer                  | share                         | share                 | read, share                  |


Note: the detailed example cases are now done in the suite that has share_folder set to Shares, so they can run on OCIS.

phil-davis · 2020-09-29T11:21:14Z

...atures/webUISharingPermissionToRoot/sharedFolderWithMultipleUsersAdvancedPermissions.feature

+    And as "user4" folder "simple-folder (2)" should not exist
+    Examples:
+      | role                 | displayed-role       | extra-permissions             | displayed-permissions | actual-permissions           |
+      # | Advanced permissions | Advanced permissions | delete                        | delete                | read, delete                 |


Note: the detailed example cases are now done in the suite that has share_folder set to Shares, so they can run on OCIS.

phil-davis · 2020-09-29T11:21:38Z

tests/acceptance/features/webUISharingPermissionsUsers/sharePermissionsUsers.feature

    Then user "User One" should be listed as "<displayed-role>" in the collaborators list for folder "simple-folder" on the webUI
    And custom permissions "<displayed-permissions>" should be set for user "User One" for folder "simple-folder" on the webUI
-    And user "user1" should have received a share with these details:
+    Then user "user1" should have received a share with these details:


Suggested change

Then user "user1" should have received a share with these details:

And user "user1" should have received a share with these details:

phil-davis · 2020-09-29T11:21:55Z

tests/acceptance/features/webUISharingPermissionsUsers/sharePermissionsUsers.feature

    Then user "User One" should be listed as "<displayed-role>" in the collaborators list for file "lorem.txt" on the webUI
    And custom permissions "<displayed-permissions>" should be set for user "User One" for file "lorem.txt" on the webUI
-    And user "user1" should have received a share with these details:
+    Then user "user1" should have received a share with these details:


Suggested change

Then user "user1" should have received a share with these details:

And user "user1" should have received a share with these details:

phil-davis · 2020-09-29T11:34:55Z

Then/And can be sorted out later. It is not really important.

dpakach mentioned this pull request Sep 25, 2020

enable sharing tests owncloud/ocis#518

Closed

2 tasks

dpakach force-pushed the refactor-permission-tests branch from aa9a60a to 7ac50b0 Compare September 25, 2020 09:25

dpakach requested review from individual-it, phil-davis and haribhandari07 September 25, 2020 10:52

dpakach self-assigned this Sep 25, 2020

dpakach added dev:acceptance-tests QA:team labels Sep 25, 2020

dpakach marked this pull request as ready for review September 25, 2020 10:53

individual-it reviewed Sep 29, 2020

View reviewed changes

[Tests-Only] refactor permission tests for shares folder

2540bc7

dpakach force-pushed the refactor-permission-tests branch from 7ac50b0 to 2540bc7 Compare September 29, 2020 10:37

dpakach requested a review from individual-it September 29, 2020 10:39

individual-it approved these changes Sep 29, 2020

View reviewed changes

phil-davis reviewed Sep 29, 2020

View reviewed changes

phil-davis merged commit 872333e into master Sep 29, 2020

delete-merged-branch bot deleted the refactor-permission-tests branch September 29, 2020 11:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tests-Only] refactor permission tests for shares folder #4104

[Tests-Only] refactor permission tests for shares folder #4104

dpakach commented Sep 24, 2020 •

edited

Loading

dpakach commented Sep 25, 2020

individual-it left a comment

phil-davis Sep 29, 2020

phil-davis Sep 29, 2020

phil-davis Sep 29, 2020

phil-davis Sep 29, 2020

phil-davis Sep 29, 2020

phil-davis Sep 29, 2020

phil-davis Sep 29, 2020

phil-davis Sep 29, 2020

phil-davis Sep 29, 2020

phil-davis commented Sep 29, 2020

	Then user "user2" should have received a share with these details:
	And user "user2" should have received a share with these details:

	Then user "user1" should have received a share with these details:
	And user "user1" should have received a share with these details:

[Tests-Only] refactor permission tests for shares folder #4104

[Tests-Only] refactor permission tests for shares folder #4104

Conversation

dpakach commented Sep 24, 2020 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

dpakach commented Sep 25, 2020

individual-it left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phil-davis commented Sep 29, 2020

dpakach commented Sep 24, 2020 •

edited

Loading