[Tests-Only] Refactor restrict sharing and auto completion tests #4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dpakach
changed the title
dpakach
force-pushed
the
refactor-restrict-sharing-tests
branch
from
8361d9b
to
da4254c
Compare
dpakach
requested review from
haribhandari07,
Talank,
phil-davis and
individual-it
dpakach
added
Status:Needs-Review
dpakach
force-pushed
the
refactor-restrict-sharing-tests
branch
from
da4254c
to
58e57a7
Compare
Talank
reviewed
Sep 29, 2020
Comment on lines
+9
to
11
| And the administrator has set the default folder for received shares to "Shares" | ||
| Given these users have been created with default attributes: | ||
| | username | |
There was a problem hiding this comment.
Suggested change
| And the administrator has set the default folder for received shares to "Shares" | |
| Given these users have been created with default attributes: | |
| | username | | |
| And the administrator has set the default folder for received shares to "Shares" | |
| And these users have been created with default attributes: | |
| | username | |
Comment on lines
+9
to
12
| Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no" | ||
| And the administrator has set the default folder for received shares to "Shares" | ||
| Given these users have been created with default attributes: | ||
| | username | |
There was a problem hiding this comment.
Suggested change
| Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no" | |
| And the administrator has set the default folder for received shares to "Shares" | |
| Given these users have been created with default attributes: | |
| | username | | |
| Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no" | |
| And the administrator has set the default folder for received shares to "Shares" | |
| And these users have been created with default attributes: | |
| | username | |
Comment on lines
+8
to
10
| Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no" | ||
| And the administrator has set the default folder for received shares to "Shares" | ||
| Given user "user1" has been created with default attributes |
There was a problem hiding this comment.
Suggested change
| Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no" | |
| And the administrator has set the default folder for received shares to "Shares" | |
| Given user "user1" has been created with default attributes | |
| Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no" | |
| And the administrator has set the default folder for received shares to "Shares" | |
| And user "user1" has been created with default attributes |
phil-davis
approved these changes
Sep 29, 2020
delete-merged-branch
bot
deleted the
refactor-restrict-sharing-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor webui test scenarios for using the Shares folder and root folder for shares.
Related Issue
Motivation and Context
Shares in ocis are received in Shares folder by default. To test that we need this refactor.
How Has This Been Tested?
🤖
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: