Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] refactor sharing with groups tests for shares folder #4110

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Sep 28, 2020

Description

Refactor webui test scenarios for using the Shares folder and root folder for shares.

Related Issue

Motivation and Context

Shares in ocis are received in Shares folder by default. To test that we need this refactor.

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@dpakach dpakach marked this pull request as draft September 28, 2020 04:36
@dpakach dpakach self-assigned this Sep 28, 2020
@dpakach dpakach mentioned this pull request Sep 29, 2020
2 tasks
@dpakach dpakach force-pushed the refactor-internal-group-tests branch from b4f2295 to a64589a Compare September 29, 2020 11:32
@dpakach dpakach marked this pull request as ready for review September 29, 2020 11:33
@dpakach dpakach force-pushed the refactor-internal-group-tests branch from a64589a to 17ceb6b Compare September 29, 2020 11:54
@phil-davis phil-davis self-requested a review September 29, 2020 11:55
phil-davis
phil-davis previously approved these changes Sep 29, 2020
@dpakach dpakach force-pushed the refactor-internal-group-tests branch 7 times, most recently from 1ee2e18 to d69754a Compare September 30, 2020 15:20
@dpakach dpakach force-pushed the refactor-internal-group-tests branch from d69754a to f30d7ae Compare October 1, 2020 03:45
@phil-davis phil-davis merged commit 8f8ce24 into master Oct 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the refactor-internal-group-tests branch October 1, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants