Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] enable files sharing tests for ocis #4161

Merged
merged 2 commits into from
Oct 16, 2020
Merged

[CI] enable files sharing tests for ocis #4161

merged 2 commits into from
Oct 16, 2020

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Oct 14, 2020 •
edited
Loading

Description

Enable sharing tests for webUISharingInternalUsers and webUISharingPermissionsUsers suites in CI.

Related Issue

Motivation and Context

More tests=less bug

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@dpakach dpakach force-pushed the enable-sharing-tests branch 5 times, most recently from 4291e10 to 6a90d3b Compare October 16, 2020 08:36
@dpakach dpakach marked this pull request as ready for review October 16, 2020 08:48
@dpakach dpakach self-assigned this Oct 16, 2020
@dpakach dpakach added Status:Needs-Review Needs review from a maintainer dev:acceptance-tests Type:CI Related to our Continouus Integration Solution labels Oct 16, 2020
@owncloud owncloud deleted a comment from update-docs bot Oct 16, 2020
phil-davis
phil-davis reviewed Oct 16, 2020
View reviewed changes
tests/acceptance/helpers/userSettings.js Outdated Show resolved Hide resolved
tests/acceptance/helpers/sharingHelper.js Outdated Show resolved Hide resolved
tests/acceptance/helpers/sharingHelper.js Outdated Show resolved Hide resolved
tests/acceptance/helpers/sharingHelper.js Outdated Show resolved Hide resolved
@dpakach dpakach mentioned this pull request Oct 16, 2020
Closed
2 tasks
@phil-davis phil-davis merged commit aa94e8a into master Oct 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the enable-sharing-tests branch October 16, 2020 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@dpakach dpakach

Labels
Status:Needs-Review Needs review from a maintainer Type:CI Related to our Continouus Integration Solution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpakach @phil-davis