Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] enable sharing permission tests #4208

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Conversation

individual-it
Copy link
Member

Description

  1. make multiuser / sharing permission tests demonstrate and work despite file_target in share response product#203 & creating a share with "create" permission also gives "update" permission ocis#717
  2. enable sharing permission suites to run in CI (

Related Issue

part of owncloud/ocis#518

Motivation and Context

  1. make tests work to avoid further regressions
  2. have tests that demonstrate the current behaviour
  3. even some suites don't have any actual tests, we will not forget them to add to drone when tests are enabled

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@phil-davis phil-davis merged commit 9115223 into master Oct 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the sharingPermissionTests branch October 19, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants